Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: tools/tests/run.sh

Issue 23490009: Remove temporary workaround TODOs from tools/tests/run.sh (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/tests/run.sh
===================================================================
--- tools/tests/run.sh (revision 10987)
+++ tools/tests/run.sh (working copy)
@@ -148,10 +148,7 @@
rm -rf $ACTUAL_OUTPUT_DIR
mkdir -p $ACTUAL_OUTPUT_DIR
EXPECTATIONS_TO_MODIFY_DIR="$ACTUAL_OUTPUT_DIR/gm-expectations"
- # TODO(epoger): Temporarily exclude expectations subdirs with old base-* names,
- # during a transition period (we need the svn rm of those subdirs to take
- # effect)
- BUILDERS=$(ls $COPY_EXPECTATIONS_FROM_DIR | grep -v ^base-)
+ BUILDERS=$(ls $COPY_EXPECTATIONS_FROM_DIR)
for BUILDER in $BUILDERS; do
mkdir -p $EXPECTATIONS_TO_MODIFY_DIR/$BUILDER
cp $COPY_EXPECTATIONS_FROM_DIR/$BUILDER/expected-results.json \
@@ -162,17 +159,7 @@
$COMMAND &>$ACTUAL_OUTPUT_DIR/stdout
echo $? >$ACTUAL_OUTPUT_DIR/return_value
- # TODO(epoger): Temporarily override compare_directories with a comparison
- # that excludes expectations subdirs with old base-* names,
- # during a transition period (we need the svn rm of those subdirs to take
- # effect)
- #
- # WAS: compare_directories $EXPECTED_OUTPUT_DIR $ACTUAL_OUTPUT_DIR
- diff --recursive --exclude=.* --exclude=base-* $EXPECTED_OUTPUT_DIR $ACTUAL_OUTPUT_DIR
- if [ $? != 0 ]; then
- echo "failed in: compare_directories $EXPECTED_OUTPUT_DIR $ACTUAL_OUTPUT_DIR"
- exit 1
- fi
+ compare_directories $EXPECTED_OUTPUT_DIR $ACTUAL_OUTPUT_DIR
}
# Run jsondiff.py with arguments in $1, recording its output.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698