sdk/lib/_internal/lib/regexp_helper.dart - Issue 23490008: Fix implementations of Match too, to use "input", not "str".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/regexp_helper.dart

Issue 23490008: Fix implementations of Match too, to use "input", not "str". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/lib/regexp_helper.dart

diff --git a/sdk/lib/_internal/lib/regexp_helper.dart b/sdk/lib/_internal/lib/regexp_helper.dart

index 94b015f12867ef767d03c8d2de528d5ec2124808..bec8253b533edfb31326fec9366b0abb70fb1d12 100644

--- a/sdk/lib/_internal/lib/regexp_helper.dart

+++ b/sdk/lib/_internal/lib/regexp_helper.dart

@@ -150,7 +150,9 @@ class _MatchImplementation implements Match {

assert(JS("var", "#.index", _match) is int);

}

- String get str => JS("String", "#.input", _match);

+ // TODO(12843): Remove when grace period is over.

+ String get str => input;

+ String get input => JS("String", "#.input", _match);

int get start => JS("int", "#.index", _match);

int get end => start + _match[0].length;

« no previous file with comments | « runtime/lib/string_patch.dart ('k') | sdk/lib/_internal/lib/string_helper.dart » ('j') | no next file with comments »