Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2348953002: Remove stl_util's STLDeleteContainerPairSecondPointers from ui/. (Closed)

Created:
4 years, 3 months ago by Avi (use Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's STLDeleteContainerPairSecondPointers from ui/. BUG=555865 Committed: https://crrev.com/9493013b80798e6b43a42a3ccbcd71bb7764830c Cr-Commit-Position: refs/heads/master@{#419512}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -70 lines) Patch
M ui/display/chromeos/x11/native_display_delegate_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 2 5 chunks +9 lines, -13 lines 0 comments Download
M ui/views/focus/view_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/view_storage.cc View 1 2 3 5 chunks +20 lines, -44 lines 1 comment Download

Messages

Total messages: 25 (19 generated)
Avi (use Gerrit)
4 years, 3 months ago (2016-09-16 21:34:30 UTC) #16
Nico
lgtm https://codereview.chromium.org/2348953002/diff/60001/ui/views/focus/view_storage.cc File ui/views/focus/view_storage.cc (right): https://codereview.chromium.org/2348953002/diff/60001/ui/views/focus/view_storage.cc#newcode83 ui/views/focus/view_storage.cc:83: } else if (ids.size() == 1) { pulling ...
4 years, 3 months ago (2016-09-19 17:32:30 UTC) #19
Nico
lgtm
4 years, 3 months ago (2016-09-19 17:33:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348953002/60001
4 years, 3 months ago (2016-09-19 17:37:21 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-19 18:30:21 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 18:31:56 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9493013b80798e6b43a42a3ccbcd71bb7764830c
Cr-Commit-Position: refs/heads/master@{#419512}

Powered by Google App Engine
This is Rietveld 408576698