Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: src/runtime.cc

Issue 234893003: Revert "Handlify GetProperty." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index b93f9573605d4e1faf1bc7cf647f877c28947350..53b18e8e178a5c1f003301d469c74db0a5e694e5 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -6047,11 +6047,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_GetArgumentsProperty) {
HandleScope scope(isolate);
if (args[0]->IsSymbol()) {
// Lookup in the initial Object.prototype object.
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result,
- Object::GetProperty(
- isolate->initial_object_prototype(), args.at<Symbol>(0)));
+ Handle<Object> result = Object::GetProperty(
+ isolate->initial_object_prototype(), args.at<Symbol>(0));
+ RETURN_IF_EMPTY_HANDLE(isolate, result);
return *result;
}
@@ -6089,10 +6087,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_GetArgumentsProperty) {
}
// Lookup in the initial Object.prototype object.
- Handle<Object> result;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, result,
- Object::GetProperty(isolate->initial_object_prototype(), key));
+ Handle<Object> result = Object::GetProperty(
+ isolate->initial_object_prototype(), key);
+ RETURN_IF_EMPTY_HANDLE(isolate, result);
return *result;
}
@@ -9311,11 +9308,9 @@ static ObjectPair LoadContextSlotHelper(Arguments args,
// No need to unhole the value here. This is taken care of by the
// GetProperty function.
- Handle<Object> value;
- ASSIGN_RETURN_ON_EXCEPTION_VALUE(
- isolate, value,
- Object::GetProperty(object, name),
- MakePair(Failure::Exception(), NULL));
+ Handle<Object> value = Object::GetProperty(object, name);
+ RETURN_IF_EMPTY_HANDLE_VALUE(
+ isolate, value, MakePair(Failure::Exception(), NULL));
return MakePair(*value, *receiver_handle);
}
« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698