Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2263)

Unified Diff: chrome/browser/resources/settings/device_page/device_page.html

Issue 2348913002: Port storage manager to MD settings. (Closed)
Patch Set: histograms.xml Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/device_page.html
diff --git a/chrome/browser/resources/settings/device_page/device_page.html b/chrome/browser/resources/settings/device_page/device_page.html
index 8e257d91ed12afacc0ea0ba13c36e7334d70c6da..05f0c7f052a331d242ef7b769d96b64e3f918e45 100644
--- a/chrome/browser/resources/settings/device_page/device_page.html
+++ b/chrome/browser/resources/settings/device_page/device_page.html
@@ -7,8 +7,9 @@
<link rel="import" href="/device_page/device_page_browser_proxy.html">
<link rel="import" href="/device_page/display.html">
<link rel="import" href="/device_page/keyboard.html">
-<link rel="import" href="/device_page/stylus.html">
<link rel="import" href="/device_page/pointers.html">
+<link rel="import" href="/device_page/storage.html">
+<link rel="import" href="/device_page/stylus.html">
<link rel="import" href="/icons.html">
<link rel="import" href="/prefs/prefs.html">
<link rel="import" href="/route.html">
@@ -46,6 +47,13 @@
<iron-icon icon="settings:desktop-windows"></iron-icon>
<div class="middle">$i18n{displayTitle}</div>
</div>
+ <template is="dom-if" if=[[showStorageManager_]]>
michaelpg 2016/10/01 01:41:04 quotes around attributes
fukino 2016/10/03 18:40:41 Done. I did the same fix for stylusAllowed_ too.
+ <div id="storageRow" class="settings-box" on-tap="onStorageTap_"
+ actionable>
+ <iron-icon icon="settings:storage"></iron-icon>
+ <div class="middle">$i18n{storageTitle}</div>
+ </div>
+ </template>
</neon-animatable>
<template is="dom-if" route-path="/pointer-overlay">
<settings-subpage
@@ -79,6 +87,15 @@
<settings-display></settings-display>
</settings-subpage>
</template>
+ <template is="dom-if" if=[[showStorageManager_]]>
michaelpg 2016/10/01 01:41:04 quotes
fukino 2016/10/03 18:40:41 Done.
+ <template is="dom-if" route-path="/storage">
+ <settings-subpage
+ associated-control="[[$$('#storageRow')]]"
+ page-title="$i18n{storageTitle}">
+ <settings-storage></settings-storage>
+ </settings-subpage>
+ </template>
+ </template>
</settings-animated-pages>
</template>
<script src="device_page.js"></script>

Powered by Google App Engine
This is Rietveld 408576698