Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2348903002:
PlzNavigate: update layout test filter (Closed)
DescriptionPlzNavigate: update layout test filter
This updates the Flag expectations for PlzNavigate, adding a test that
started failing, and removing several tests that no longer fail/exist.
BUG=576261
Committed: https://crrev.com/d129d3a3504a6f3c6e9f4c574144200c715a5dcf
Cr-Commit-Position: refs/heads/master@{#419478}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Re-added failing inspector tests #Messages
Total messages: 20 (11 generated)
The CQ bit was checked by clamy@chromium.org to run a CQ dry run
Description was changed from ========== PlzNavigate: update layout test filter This updates the Flag expectations for PlzNavigate, adding a test that started failing, and removing several tests that no longer fail/exist. BUG=576261 ========== to ========== PlzNavigate: update layout test filter This updates the Flag expectations for PlzNavigate, adding a test that started failing, and removing several tests that no longer fail/exist. BUG=576261 ==========
clamy@chromium.org changed reviewers: + scottmg@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
@scottmg: PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2348903002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation (left): https://codereview.chromium.org/2348903002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation:68: inspector/tracing/timeline-misc/timeline-auto-record.html [ Failure Crash ] Looks like these ones shouldn't be removed. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
https://codereview.chromium.org/2348903002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation (left): https://codereview.chromium.org/2348903002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation:68: inspector/tracing/timeline-misc/timeline-auto-record.html [ Failure Crash ] On 2016/09/16 16:29:40, scottmg wrote: > Looks like these ones shouldn't be removed. > > https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... Done.
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by scottmg@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: update layout test filter This updates the Flag expectations for PlzNavigate, adding a test that started failing, and removing several tests that no longer fail/exist. BUG=576261 ========== to ========== PlzNavigate: update layout test filter This updates the Flag expectations for PlzNavigate, adding a test that started failing, and removing several tests that no longer fail/exist. BUG=576261 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: update layout test filter This updates the Flag expectations for PlzNavigate, adding a test that started failing, and removing several tests that no longer fail/exist. BUG=576261 ========== to ========== PlzNavigate: update layout test filter This updates the Flag expectations for PlzNavigate, adding a test that started failing, and removing several tests that no longer fail/exist. BUG=576261 Committed: https://crrev.com/d129d3a3504a6f3c6e9f4c574144200c715a5dcf Cr-Commit-Position: refs/heads/master@{#419478} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d129d3a3504a6f3c6e9f4c574144200c715a5dcf Cr-Commit-Position: refs/heads/master@{#419478} |
