Prune createVisiblePositionDeprecated from HTMLTextFormControlElement

Prune createVisiblePositionDeprecated from HTMLTextFormControlElement

This patch prunes createVisiblePositionDeprecated from
HTMLTextFormControlElement::visiblePositionForIndex.

It also finds several loopholes that may end up calling visiblePositionForIndex
with dirty layout, and adds layout update calls there.

BUG=647219
Committed: https://crrev.com/04abd8d88e17a3644c7f60be294fb78daa87cf17
Cr-Commit-Position: refs/heads/master@{#419665}

[Xiaocheng, 2016-09-16 11:58:01]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 11:58:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-16 12:00:18]

Description was changed from

==========
Prune createVisiblePositionDeprecated from HTMLTextFormControlElement

BUG=
==========

to

==========
Prune createVisiblePositionDeprecated from HTMLTextFormControlElement

This patch prunes createVisiblePositionDeprecated from
HTMLTextFormControlElement::visiblePositionForIndex.

It also finds several loopholes that may end up calling visiblePositionForIndex
with dirty layout, and adds layout update calls there.

BUG=647219
==========

[commit-bot: I haz the power, 2016-09-16 13:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 13:12:33]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-16 14:54:38]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-09-16 14:54:38]

PTAL.

[tkent, 2016-09-20 00:34:13]

> It also finds several loopholes that may end up calling
visiblePositionForIndex
> with dirty layout, and adds layout update calls there.

Does it mean SpellChecker::selectionStartHasSpellingMarkerFor() calls
HTMLTextFormControlElement::visiblePositionForIndex()?

[Xiaocheng, 2016-09-20 01:36:06]

On 2016/09/20 at 00:34:13, tkent wrote:
> > It also finds several loopholes that may end up calling
visiblePositionForIndex
> > with dirty layout, and adds layout update calls there.
> 
> Does it mean SpellChecker::selectionStartHasSpellingMarkerFor() calls
HTMLTextFormControlElement::visiblePositionForIndex()?

Yes, via a static function findFirstMarkable() in SpellChecker.cpp.

[tkent, 2016-09-20 01:42:21]

lgtm

[Xiaocheng, 2016-09-20 01:46:11]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:46:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 03:10:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 03:12:17]

Description was changed from

==========
Prune createVisiblePositionDeprecated from HTMLTextFormControlElement

This patch prunes createVisiblePositionDeprecated from
HTMLTextFormControlElement::visiblePositionForIndex.

It also finds several loopholes that may end up calling visiblePositionForIndex
with dirty layout, and adds layout update calls there.

BUG=647219
==========

to

==========
Prune createVisiblePositionDeprecated from HTMLTextFormControlElement

This patch prunes createVisiblePositionDeprecated from
HTMLTextFormControlElement::visiblePositionForIndex.

It also finds several loopholes that may end up calling visiblePositionForIndex
with dirty layout, and adds layout update calls there.

BUG=647219

Committed: https://crrev.com/04abd8d88e17a3644c7f60be294fb78daa87cf17
Cr-Commit-Position: refs/heads/master@{#419665}
==========

[commit-bot: I haz the power, 2016-09-20 03:12:18]

Patchset 1 (id:??) landed as
https://crrev.com/04abd8d88e17a3644c7f60be294fb78daa87cf17
Cr-Commit-Position: refs/heads/master@{#419665}