Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2348893002: Prune createVisiblePositionDeprecated from HTMLTextFormControlElement (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisiblePositionDeprecated from HTMLTextFormControlElement This patch prunes createVisiblePositionDeprecated from HTMLTextFormControlElement::visiblePositionForIndex. It also finds several loopholes that may end up calling visiblePositionForIndex with dirty layout, and adds layout update calls there. BUG=647219 Committed: https://crrev.com/04abd8d88e17a3644c7f60be294fb78daa87cf17 Cr-Commit-Position: refs/heads/master@{#419665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-16 14:54:38 UTC) #7
tkent
> It also finds several loopholes that may end up calling visiblePositionForIndex > with dirty ...
4 years, 3 months ago (2016-09-20 00:34:13 UTC) #8
Xiaocheng
On 2016/09/20 at 00:34:13, tkent wrote: > > It also finds several loopholes that may ...
4 years, 3 months ago (2016-09-20 01:36:06 UTC) #9
tkent
lgtm
4 years, 3 months ago (2016-09-20 01:42:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348893002/1
4 years, 3 months ago (2016-09-20 01:46:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 03:10:36 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 03:12:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04abd8d88e17a3644c7f60be294fb78daa87cf17
Cr-Commit-Position: refs/heads/master@{#419665}

Powered by Google App Engine
This is Rietveld 408576698