Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2999)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 2348853004: Remove non-md code in location bar (Views). (Closed)
Patch Set: images Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index 49fc5998006d3e58ee6a19145696b347116e1172..2006f0bf2fa80f6f18d8ea45a7430a5788f93fec 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -123,8 +123,8 @@ class LocationBarView : public LocationBar,
~LocationBarView() override;
- // Returns the color for the location bar border in MD windows and non-MD
- // popup windows, given the window's |incognito| state.
+ // Returns the color for the location bar border in Windows, given the
Peter Kasting 2016/09/19 23:46:46 Nit: Should have been "windows" rather than "Windo
Evan Stade 2016/09/20 17:37:04 Done.
+ // window's |incognito| state.
static SkColor GetBorderColor(bool incognito);
// Initializes the LocationBarView.
@@ -371,7 +371,6 @@ class LocationBarView : public LocationBar,
void OnBoundsChanged(const gfx::Rect& previous_bounds) override;
void OnFocus() override;
void OnPaint(gfx::Canvas* canvas) override;
- void PaintChildren(const ui::PaintContext& context) override;
// views::DragController:
void WriteDragDataForView(View* sender,
@@ -406,9 +405,6 @@ class LocationBarView : public LocationBar,
// Our delegate.
Delegate* delegate_;
- // Object used to paint the border. Not used for material design.
- std::unique_ptr<views::Painter> border_painter_;
-
// An icon to the left of the edit field: the HTTPS lock, blank page icon,
// search icon, EV HTTPS bubble, etc.
LocationIconView* location_icon_view_;

Powered by Google App Engine
This is Rietveld 408576698