Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2348853003: Don't include LayoutViewItem.h from StyleResolverState.h (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, caseq+blink_chromium.org, krit, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, rwlbuis, blink-reviews-style_chromium.org, sof, lushnikov+blink_chromium.org, darktears, pfeldman+blink_chromium.org, f(malita), Stephen Chennney, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include LayoutViewItem.h from StyleResolverState.h This reduces the number of compilation units that depend on files like LayoutBlock.h by more than 200 (from around 500 to around 280). Committed: https://crrev.com/50afd4c0e3a555679dbb66cada11732f62231008 Cr-Commit-Position: refs/heads/master@{#419202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.h View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
You Google folks should shut down GOMA for a month just to see how it ...
4 years, 3 months ago (2016-09-16 14:25:57 UTC) #4
eae
LGTM, thank you! On 2016/09/16 14:25:57, mstensho wrote: > You Google folks should shut down ...
4 years, 3 months ago (2016-09-16 14:40:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348853003/1
4 years, 3 months ago (2016-09-16 17:28:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 17:35:03 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 17:37:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50afd4c0e3a555679dbb66cada11732f62231008
Cr-Commit-Position: refs/heads/master@{#419202}

Powered by Google App Engine
This is Rietveld 408576698