Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: build/symlink.gni

Issue 2348793002: Use a stamp file when symlinking in GN work around mtime issues (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/symlink.gni
diff --git a/build/symlink.gni b/build/symlink.gni
index 95a498de1b48e0123435e649124f33668d066a7e..174278cbe601664822623db61c8c2bc40223ee82 100644
--- a/build/symlink.gni
+++ b/build/symlink.gni
@@ -14,11 +14,17 @@ template("symlink") {
"testonly",
"visibility",
])
+
+ # Can't use the symlink itself as an output since ninja does not properly
+ # process the symlink's mtime.
+ # https://github.com/ninja-build/ninja/issues/1186
outputs = [
- invoker.output,
+ "$target_gen_dir/$target_name.stamp",
]
script = "//build/symlink.py"
args = [
+ "--touch",
+ rebase_path(outputs[0], root_build_dir),
"-f",
rebase_path(invoker.source, get_path_info(invoker.output, "dir")),
rebase_path(invoker.output, root_build_dir),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698