Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2348783002: [AST] Add method to concatenate AstRawStrings (Closed)

Created:
4 years, 3 months ago by bakkot
Modified:
4 years, 3 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[AST] Add method to concatenate AstRawStrings Normally the parser just uses AstConsStrings to concatenate, but some types require an AstRawString. This patch adds an AstValueFactory method which produces one from two AstRawStrings. Committed: https://crrev.com/e68258bd154a756bbf8a84a7edf386da2db05da2 Cr-Commit-Position: refs/heads/master@{#39482}

Patch Set 1 #

Patch Set 2 : memcpy and test #

Patch Set 3 : use ConcatString #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -31 lines) Patch
M src/ast/ast-value-factory.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 2 12 chunks +164 lines, -9 lines 0 comments Download
M src/parsing/parser-base.h View 1 2 9 chunks +38 lines, -8 lines 0 comments Download
M src/parsing/preparser.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/preparser.cc View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M src/parsing/scanner.cc View 1 2 4 chunks +7 lines, -2 lines 0 comments Download
M src/parsing/token.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 chunks +99 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/class-privates-delete.js View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
A test/mjsunit/harmony/class-privates-errors.js View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/class-privates-evaluation-order.js View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/class-privates-proxy.js View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/class-privates-scoping.js View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/class-privates-visibility.js View 1 2 1 chunk +93 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
bakkot
PTAL. This isn't tested at all, so don't merge quite yet, but I believe it ...
4 years, 3 months ago (2016-09-16 01:40:59 UTC) #2
bakkot
This now has a test and a slightly less dumb implementation.
4 years, 3 months ago (2016-09-16 21:42:17 UTC) #3
adamk
lgtm
4 years, 3 months ago (2016-09-16 22:24:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348783002/20001
4 years, 3 months ago (2016-09-16 23:33:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 23:49:20 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 23:49:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e68258bd154a756bbf8a84a7edf386da2db05da2
Cr-Commit-Position: refs/heads/master@{#39482}

Powered by Google App Engine
This is Rietveld 408576698