Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2348703002:
[Blink, RemotePlayback] Added the disableRemotePlayback check to prompt(). (Closed)
|
Created:
4 years, 3 months ago by whywhat Modified:
4 years, 2 months ago Reviewers:
mlamouri (slow - plz ping) CC:
blink-reviews, chromium-reviews, haraken Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Blink, RemotePlayback] Added the disableRemotePlayback check to prompt().
BUG=647441
TEST=avayvod.github.io/remote-playback/test.html and a layout test
Committed: https://crrev.com/0e1ec531a7d344a79e4a9ab24644c10f7dde475f
Cr-Commit-Position: refs/heads/master@{#421436}
Patch Set 1 #Patch Set 2 : Added layout test #Patch Set 3 : Rebase #Patch Set 4 : Removed the newline from expected.txt #
Dependent Patchsets: Messages
Total messages: 28 (16 generated)
avayvod@chromium.org changed reviewers: + mlamouri@chromium.org
The CQ bit was checked by avayvod@chromium.org to run a CQ dry run
PTaL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Added layout test
The CQ bit was checked by avayvod@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
You might want to update the TEST= line.
Rebase
Description was changed from ========== [Blink, RemotePlayback] Added the disableRemotePlayback check to prompt(). BUG=647441 TEST=manual with avayvod.github.io/remote-playback/test.html ========== to ========== [Blink, RemotePlayback] Added the disableRemotePlayback check to prompt(). BUG=647441 TEST=avayvod.github.io/remote-playback/test.html and a layout test ==========
The CQ bit was checked by avayvod@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mlamouri@chromium.org Link to the patchset: https://codereview.chromium.org/2348703002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Removed the newline from expected.txt
The CQ bit was checked by avayvod@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mlamouri@chromium.org Link to the patchset: https://codereview.chromium.org/2348703002/#ps60001 (title: "Removed the newline from expected.txt")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Blink, RemotePlayback] Added the disableRemotePlayback check to prompt(). BUG=647441 TEST=avayvod.github.io/remote-playback/test.html and a layout test ========== to ========== [Blink, RemotePlayback] Added the disableRemotePlayback check to prompt(). BUG=647441 TEST=avayvod.github.io/remote-playback/test.html and a layout test Committed: https://crrev.com/0e1ec531a7d344a79e4a9ab24644c10f7dde475f Cr-Commit-Position: refs/heads/master@{#421436} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0e1ec531a7d344a79e4a9ab24644c10f7dde475f Cr-Commit-Position: refs/heads/master@{#421436} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
