Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2348693004: [Android] Enable @RetryOnFailure. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py
diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
index 9f743353f992bf282a84cb739ef018c5f94af102..cae27b3b26462171a406d644e911ef9500bb2ca6 100644
--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py
+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
@@ -347,11 +347,10 @@ class LocalDeviceInstrumentationTestRun(
if 'RetryOnFailure' in test.get('annotations', {}):
return True
- # TODO(jbudorick): Remove this log message and switch the return value to
- # False after tests have been annotated with @RetryOnFailure.
- # See crbug.com/619055 for more details.
- logging.warning('Default retries are being phased out. crbug.com/619055')
- return True
+ # TODO(jbudorick): Remove this log message once @RetryOnFailure has been
+ # enabled for a while. See crbug.com/619055 for more details.
+ logging.error('Default retries are being phased out. crbug.com/619055')
+ return False
#override
def _ShouldShard(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698