Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Issue 2348673003: Ship Observatory with non-minified sources (Closed)

Created:
4 years, 3 months ago by Cutch
Modified:
4 years, 3 months ago
Reviewers:
rmacnak, kevmoo
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ship Observatory with non-minified sources This will help our users report more actionable bug reports. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/cbbb82cfbe9f5fc20da81726bd28d5cf51d0af7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/observatory/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Cutch
4 years, 3 months ago (2016-09-16 19:38:59 UTC) #3
rmacnak
LGTM
4 years, 3 months ago (2016-09-16 19:42:46 UTC) #4
Cutch
Committed patchset #1 (id:1) manually as cbbb82cfbe9f5fc20da81726bd28d5cf51d0af7a (presubmit successful).
4 years, 3 months ago (2016-09-16 20:00:45 UTC) #6
kevmoo
DBQ: what's the size delta unminified?
4 years, 3 months ago (2016-09-16 20:59:02 UTC) #8
Cutch
4 years, 3 months ago (2016-09-19 14:56:43 UTC) #9
Message was sent while issue was closed.
On 2016/09/16 20:59:02, kevmoo wrote:
> DBQ: what's the size delta unminified?

1) Size delta of JavaScript output: +2 MB (1MB -> 3MB).

2) Size delta of compressed output linked into executable: +0.8MB.

Powered by Google App Engine
This is Rietveld 408576698