Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(36)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/chromeos/arc/page_transition_util.h
Issue
2348673002
:
Add an external protocol dialog for ARC (Closed)
Patch Set: Address Xiyuan's comment
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/chromeos/BUILD.gn
chrome/browser/chromeos/arc/arc_external_protocol_dialog.h
chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc
chrome/browser/chromeos/arc/arc_navigation_throttle.cc
chrome/browser/chromeos/arc/page_transition_util.h
chrome/browser/chromeos/arc/page_transition_util.cc
chrome/browser/chromeos/external_protocol_dialog.cc
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/chromeos/arc/arc_navigation_throttle.cc
('k') |
chrome/browser/chromeos/arc/page_transition_util.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#ifndef CHROME_BROWSER_CHROMEOS_ARC_PAGE_TRANSITION_UTIL_H_
6
#define CHROME_BROWSER_CHROMEOS_ARC_PAGE_TRANSITION_UTIL_H_
7
8
#include "ui/base/page_transition_types.h"
9
10
namespace arc {
11
12
// Returns true if ARC should ignore the navigation with the |page_transition|.
13
bool ShouldIgnoreNavigation(ui::PageTransition page_transition);
14
15
} // namespace arc
16
17
#endif // CHROME_BROWSER_CHROMEOS_ARC_PAGE_TRANSITION_UTIL_H_
OLD
NEW
« no previous file with comments
|
« chrome/browser/chromeos/arc/arc_navigation_throttle.cc
('k') |
chrome/browser/chromeos/arc/page_transition_util.cc »
('j') |
no next file with comments »
Issue 2348673002: Add an external protocol dialog for ARC (Closed)
Created 4 years, 3 months ago by Yusuke Sato
Modified 4 years, 3 months ago
Reviewers: Luis Héctor Chávez, xiyuan
Base URL:
Comments: 12
This is Rietveld
408576698
Chromium Code Reviews
Issue 2348673002:
Add an external protocol dialog for ARC (Closed)
