content/browser/accessibility/dump_accessibility_tree_browsertest.cc - Issue 2348663002: Mac accessibility: only use AXTitleUIElement if that element has valid text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 2348663002: Mac accessibility: only use AXTitleUIElement if that element has valid text. (Closed)

Patch Set: Fix last expectation Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/test/data/accessibility/aria/aria-posinset-expected-mac.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

index f49ee13bde27d4e36e855c3da99229d41a3e8b73..004b8644aa550430581bb0fe762ddd7b8e4ddf2e 100644

--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

@@ -970,6 +970,11 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,

RunHtmlTest(FILE_PATH_LITERAL("input-checkbox-in-menu.html"));

}

+IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,

+ AccessibilityInputCheckBoxLabel) {

+ RunHtmlTest(FILE_PATH_LITERAL("input-checkbox-label.html"));

IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityInputColor) {

RunHtmlTest(FILE_PATH_LITERAL("input-color.html"));

}