Make sure to to check weak ptr validity before use in UnpackedInstaller

Make sure to to check weak ptr validity before use in UnpackedInstaller

The stack in this crash report indicates that we're inside
UnpackedInstaller::InstallExtension, and we know that function gets
called via a posted task (via OnInstallChecksComplete). The code inside
InstallExtension uses the weak pointer to the ExtensionService without
validating it first, so we strongly suspect a null ExtensionService to
be the root cause of the crash.

BUG=647265
Committed: https://crrev.com/1e46c51094e8d7576226ae3f119ad1b266f0aa7f
Cr-Commit-Position: refs/heads/master@{#419060}

[asargent_no_longer_on_chrome, 2016-09-15 21:35:56]

asargent@chromium.org changed reviewers:
+ lazyboy@chromium.org

[asargent_no_longer_on_chrome, 2016-09-15 21:40:06]

The CQ bit was checked by asargent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 21:40:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2016-09-15 21:45:09]

lgtm.

https://codereview.chromium.org/2348633002/diff/1/chrome/browser/extensions/u...
File chrome/browser/extensions/unpacked_installer.cc (right):

https://codereview.chromium.org/2348633002/diff/1/chrome/browser/extensions/u...
chrome/browser/extensions/unpacked_installer.cc:372: if (!service_weak_.get())
Should we also Reset |callback_|?

[commit-bot: I haz the power, 2016-09-15 23:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:03:44]

Dry run: This issue passed the CQ dry run.

[asargent_no_longer_on_chrome, 2016-09-16 00:03:24]

https://codereview.chromium.org/2348633002/diff/1/chrome/browser/extensions/u...
File chrome/browser/extensions/unpacked_installer.cc (right):

https://codereview.chromium.org/2348633002/diff/1/chrome/browser/extensions/u...
chrome/browser/extensions/unpacked_installer.cc:372: if (!service_weak_.get())
On 2016/09/15 21:45:09, lazyboy wrote:
> Should we also Reset |callback_|?

Good suggestion. Done.

[asargent_no_longer_on_chrome, 2016-09-16 00:03:28]

The CQ bit was checked by asargent@chromium.org

[asargent_no_longer_on_chrome, 2016-09-16 00:03:29]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2348633002/#ps20001
(title: "reset callback")

[commit-bot: I haz the power, 2016-09-16 00:04:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 00:46:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 00:48:38]

Description was changed from

==========
Make sure to to check weak ptr validity before use in UnpackedInstaller

The stack in this crash report indicates that we're inside
UnpackedInstaller::InstallExtension, and we know that function gets
called via a posted task (via OnInstallChecksComplete). The code inside
InstallExtension uses the weak pointer to the ExtensionService without
validating it first, so we strongly suspect a null ExtensionService to
be the root cause of the crash.

BUG=647265
==========

to

==========
Make sure to to check weak ptr validity before use in UnpackedInstaller

The stack in this crash report indicates that we're inside
UnpackedInstaller::InstallExtension, and we know that function gets
called via a posted task (via OnInstallChecksComplete). The code inside
InstallExtension uses the weak pointer to the ExtensionService without
validating it first, so we strongly suspect a null ExtensionService to
be the root cause of the crash.

BUG=647265

Committed: https://crrev.com/1e46c51094e8d7576226ae3f119ad1b266f0aa7f
Cr-Commit-Position: refs/heads/master@{#419060}
==========

[commit-bot: I haz the power, 2016-09-16 00:48:40]

Patchset 2 (id:??) landed as
https://crrev.com/1e46c51094e8d7576226ae3f119ad1b266f0aa7f
Cr-Commit-Position: refs/heads/master@{#419060}