Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 234863002: Oilpan: Enable Oilpan in modules/encoding (Closed)

Created:
6 years, 8 months ago by haraken
Modified:
6 years, 8 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Oilpan: Enable Oilpan in modules/encoding BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171419

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/modules/encoding/TextDecoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encoding/TextDecoder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/encoding/TextDecoder.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encoding/TextEncoder.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/encoding/TextEncoder.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
haraken
PTAL (I'll land this CL on Monday after confirming that the Gamepad CL doesn't cause ...
6 years, 8 months ago (2014-04-11 09:45:42 UTC) #1
haraken
https://codereview.chromium.org/234863002/diff/10001/Source/modules/encoding/TextDecoder.cpp File Source/modules/encoding/TextDecoder.cpp (right): https://codereview.chromium.org/234863002/diff/10001/Source/modules/encoding/TextDecoder.cpp#newcode48 Source/modules/encoding/TextDecoder.cpp:48: return 0; We need to change nullptr to 0 ...
6 years, 8 months ago (2014-04-11 09:46:33 UTC) #2
Mads Ager (chromium)
LGTM with a couple of more nullptr replaced. :) https://codereview.chromium.org/234863002/diff/10001/Source/modules/encoding/TextDecoder.cpp File Source/modules/encoding/TextDecoder.cpp (right): https://codereview.chromium.org/234863002/diff/10001/Source/modules/encoding/TextDecoder.cpp#newcode48 Source/modules/encoding/TextDecoder.cpp:48: ...
6 years, 8 months ago (2014-04-11 10:19:24 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-14 04:11:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/234863002/30001
6 years, 8 months ago (2014-04-14 04:11:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 04:45:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-14 04:45:14 UTC) #7
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-14 04:46:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/234863002/30001
6 years, 8 months ago (2014-04-14 04:46:32 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 05:15:14 UTC) #10
Message was sent while issue was closed. 
Change committed as 171419

Powered by Google App Engine
This is Rietveld 408576698