Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2348603003: Increase HPACK table size up to the optimal size if clients allow it. (Closed)

Created:
4 years, 3 months ago by yasong
Modified:
4 years, 3 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase HPACK table size up to the optimal size if clients allow it. This CL lands server change 133042402 by yasong@. BUG=488484 Committed: https://crrev.com/219c2a7a6c8f5bc57e6d375e9ce08c5a4d6f2712 Cr-Commit-Position: refs/heads/master@{#419235}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M net/spdy/hpack/hpack_header_table.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/spdy/hpack/hpack_header_table_test.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M net/spdy/spdy_flags.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
yasong
On 2016/09/16 14:04:37, yasong wrote: > mailto:yasong@chromium.org changed reviewers: > + mailto:bnc@chromium.org Ready for review. ...
4 years, 3 months ago (2016-09-16 14:05:02 UTC) #13
Bence
LGTM with nit. https://codereview.chromium.org/2348603003/diff/1/net/spdy/spdy_flags.h File net/spdy/spdy_flags.h (right): https://codereview.chromium.org/2348603003/diff/1/net/spdy/spdy_flags.h#newcode18 net/spdy/spdy_flags.h:18: FLAGS_chromium_reloadable_flag_increase_hpack_table_size; Please order flags alphabetically here ...
4 years, 3 months ago (2016-09-16 16:31:53 UTC) #14
yasong
On 2016/09/16 16:31:53, Bence wrote: > LGTM with nit. > > https://codereview.chromium.org/2348603003/diff/1/net/spdy/spdy_flags.h > File net/spdy/spdy_flags.h ...
4 years, 3 months ago (2016-09-16 18:54:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348603003/20001
4 years, 3 months ago (2016-09-16 18:54:45 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 19:00:18 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:02:39 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/219c2a7a6c8f5bc57e6d375e9ce08c5a4d6f2712
Cr-Commit-Position: refs/heads/master@{#419235}

Powered by Google App Engine
This is Rietveld 408576698