Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2348603002: [chromecast] Track MediaPipelineBackend used by CastRenderer. (Closed)

Created:
4 years, 3 months ago by alokp
Modified:
4 years, 3 months ago
Reviewers:
halliwell
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, lcwu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, halliwell+watch_chromium.org, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Track MediaPipelineBackend used by CastRenderer. BUG=571155 Committed: https://crrev.com/ce99a56d17d7159b524c4d29e81a34f6880ec24e Cr-Commit-Position: refs/heads/master@{#418993}

Patch Set 1 #

Total comments: 3

Patch Set 2 : DISALLOW_COPY_AND_ASSIGN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -91 lines) Patch
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/browser/media/cast_mojo_media_client.h View 3 chunks +4 lines, -1 line 0 comments Download
M chromecast/browser/media/cast_mojo_media_client.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M chromecast/browser/media/cast_renderer.h View 4 chunks +8 lines, -2 lines 0 comments Download
M chromecast/browser/media/cast_renderer.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chromecast/media/base/media_resource_tracker.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M chromecast/media/base/media_resource_tracker.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chromecast/media/base/media_resource_tracker_unittest.cc View 9 chunks +41 lines, -80 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alokp
https://codereview.chromium.org/2348603002/diff/1/chromecast/media/base/media_resource_tracker_unittest.cc File chromecast/media/base/media_resource_tracker_unittest.cc (left): https://codereview.chromium.org/2348603002/diff/1/chromecast/media/base/media_resource_tracker_unittest.cc#oldcode75 chromecast/media/base/media_resource_tracker_unittest.cc:75: media_thread_.reset(new base::Thread("MediaThread")); I used the same task runner for ...
4 years, 3 months ago (2016-09-15 20:46:35 UTC) #2
halliwell
On 2016/09/15 20:46:35, alokp wrote: > https://codereview.chromium.org/2348603002/diff/1/chromecast/media/base/media_resource_tracker_unittest.cc > File chromecast/media/base/media_resource_tracker_unittest.cc (left): > > https://codereview.chromium.org/2348603002/diff/1/chromecast/media/base/media_resource_tracker_unittest.cc#oldcode75 > ...
4 years, 3 months ago (2016-09-15 20:54:00 UTC) #3
halliwell
https://codereview.chromium.org/2348603002/diff/1/chromecast/media/base/media_resource_tracker.h File chromecast/media/base/media_resource_tracker.h (right): https://codereview.chromium.org/2348603002/diff/1/chromecast/media/base/media_resource_tracker.h#newcode46 chromecast/media/base/media_resource_tracker.h:46: MediaResourceTracker* tracker_; nit: should DISALLOW_COPY_AND_ASSIGN
4 years, 3 months ago (2016-09-15 20:54:07 UTC) #4
alokp
https://codereview.chromium.org/2348603002/diff/1/chromecast/media/base/media_resource_tracker.h File chromecast/media/base/media_resource_tracker.h (right): https://codereview.chromium.org/2348603002/diff/1/chromecast/media/base/media_resource_tracker.h#newcode46 chromecast/media/base/media_resource_tracker.h:46: MediaResourceTracker* tracker_; On 2016/09/15 20:54:07, halliwell wrote: > nit: ...
4 years, 3 months ago (2016-09-15 21:01:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348603002/20001
4 years, 3 months ago (2016-09-15 21:03:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 21:50:24 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 21:53:48 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ce99a56d17d7159b524c4d29e81a34f6880ec24e
Cr-Commit-Position: refs/heads/master@{#418993}

Powered by Google App Engine
This is Rietveld 408576698