pkg/unittest/test/matchers_unminified_test.dart - Issue 23486007: Change the field and constructor parameter types of NoSuchMethodError to Symbol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/test/matchers_unminified_test.dart

Issue 23486007: Change the field and constructor parameter types of NoSuchMethodError to Symbol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/unittest/test/matchers_unminified_test.dart

diff --git a/pkg/unittest/test/matchers_unminified_test.dart b/pkg/unittest/test/matchers_unminified_test.dart

index 8a1b005992e3f8a6ef9f2bcfdc1beea9f77c36c9..3d7c322a8e4b3551bc0e1111f8b6793e08a1494f 100644

--- a/pkg/unittest/test/matchers_unminified_test.dart

+++ b/pkg/unittest/test/matchers_unminified_test.dart

@@ -51,8 +51,9 @@ void main() {

});

test('throwsNoSuchMethodError', () {

- shouldPass(() { throw new NoSuchMethodError(null, '', null, null); },

- throwsNoSuchMethodError);

+ shouldPass(() {

+ throw new NoSuchMethodError(null, const Symbol(''), null, null);

+ }, throwsNoSuchMethodError);

shouldFail(() { throw new Exception(); },

throwsNoSuchMethodError,

matches(

« no previous file with comments | « pkg/unittest/test/matchers_minified_test.dart ('k') | runtime/lib/errors_patch.dart » ('j') | no next file with comments »