Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: sdk/lib/js/dartium/js_dartium.dart

Issue 23486007: Change the field and constructor parameter types of NoSuchMethodError to Symbol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/js/dartium/js_dartium.dart
diff --git a/sdk/lib/js/dartium/js_dartium.dart b/sdk/lib/js/dartium/js_dartium.dart
index 5f9788be1a69898c84a0aef768f68ea395db2428..2ec2c0e5e79010f9e3e87cf3874be63bf1536e1b 100644
--- a/sdk/lib/js/dartium/js_dartium.dart
+++ b/sdk/lib/js/dartium/js_dartium.dart
@@ -211,7 +211,8 @@ class JsObject implements Serializable<JsObject> {
switch (result[0]) {
case 'return': return _deserialize(result[1]);
case 'throws': throw _deserialize(result[1]);
- case 'none': throw new NoSuchMethodError(receiver, member, args, {});
+ case 'none':
+ throw new NoSuchMethodError(receiver, new Symbol(member), args, {});
default: throw 'Invalid return value';
}
}

Powered by Google App Engine
This is Rietveld 408576698