Change the field and constructor parameter types of NoSuchMethodError to Symbol.

runtime/lib/errors_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class Error {
   /* patch */ static String _objectToString(Object object) {
     return Object._toString(object);
   }
 
   /* patch */ StackTrace get stackTrace => _stackTrace;
@@ skipping 130 matching lines @@
     if (numPositionalArguments == 0) {
       // Differ between no arguments specified and 0 arguments.
       // TODO(srdjan): This can currently occur for unresolvable static methods.
       // In that case, the arguments are evaluated but not passed to the
       // throwing stub (see EffectGraphVisitor::BuildThrowNoSuchMethodError and
       // Parser::ThrowNoSuchMethodError)).
       positionalArguments = argumentNames == null ? null : [];
     } else {
       positionalArguments = arguments.sublist(0, numPositionalArguments);
     }
-    Map<String, dynamic> namedArguments = new Map<String, dynamic>();
+    Map<Symbol, dynamic> namedArguments = new Map<Symbol, dynamic>();
     for (int i = 0; i < numNamedArguments; i++) {
       var arg_value = arguments[numPositionalArguments + i];
-      namedArguments[argumentNames[i]] = arg_value;
+      namedArguments[new Symbol(argumentNames[i])] = arg_value;
     }
     throw new NoSuchMethodError._withType(receiver,
-                                          memberName,
+                                          new Symbol(memberName),
                                           invocation_type,
                                           positionalArguments,
                                           namedArguments,
                                           existingArgumentNames);
   }
 
   // Remember the type from the invocation mirror or static compilation
   // analysis when thrown directly with _throwNew. A negative value means
   // that no information is available.
   final int _invocation_type;
 
   NoSuchMethodError(Object this._receiver,
-                    String this._memberName,
+                    Symbol this._memberName,
                     List this._arguments,
-                    Map<String,dynamic> this._namedArguments,
+                    Map<Symbol, dynamic> this._namedArguments,
                     [List existingArgumentNames = null])
       : this._existingArgumentNames = existingArgumentNames,
         this._invocation_type = -1;
 
+  // This constructor seems to be called with either strings or
+  // values read from another NoSuchMethodError.
   NoSuchMethodError._withType(Object this._receiver,
-                              String this._memberName,
+                              /*String|Symbol*/ memberName,
                               this._invocation_type,
                               List this._arguments,
-                              Map<String,dynamic> this._namedArguments,
+                              Map<dynamic, dynamic> namedArguments,
                               [List existingArgumentNames = null])
-      : this._existingArgumentNames = existingArgumentNames;
+      : this._memberName =
+            (memberName is String) ? new Symbol(memberName) : memberName,
+        this._namedArguments =
+            (namedArguments == null)
+                ? null
+                : new Map<Symbol, dynamic>.fromIterable(
+                    namedArguments.keys,
+                    key: (k) => (k is String) ? new Symbol(k) : k,
+                    value: (k) => namedArguments[k]),
+        this._existingArgumentNames = existingArgumentNames;
 
 
   String _developerMessage(args_mismatch) {
     if (_invocation_type < 0) {
       return "";
     }
     var type = _invocation_type & _InvocationMirror._TYPE_MASK;
     var level = (_invocation_type >> _InvocationMirror._CALL_SHIFT) &
          _InvocationMirror._CALL_MASK;
     var type_str =
         (const ["method", "getter", "setter", "getter or setter"])[type];
     var args_message = args_mismatch ? " with matching arguments" : "";
     var msg;
+    var memberName =
+        (_memberName == null) ? "" :_collection_dev.Symbol.getName(_memberName);
     switch (level) {
       case _InvocationMirror._DYNAMIC: {
         if (_receiver == null) {
-          msg = "The null object does not have a $type_str '$_memberName'"
+          msg = "The null object does not have a $type_str '$memberName'"
               "$args_message.";
         } else {
           if (_receiver is Function) {
             msg = "Closure call with mismatched arguments: "
-                "function '$_memberName'";
+                "function '$memberName'";
           } else {
             msg = "Class '${_receiver.runtimeType}' has no instance $type_str "
-                "'$_memberName'$args_message.";
+                "'$memberName'$args_message.";
           }
         }
         break;
       }
       case _InvocationMirror._STATIC: {
-        msg = "No static $type_str '$_memberName' declared in class "
+        msg = "No static $type_str '$memberName' declared in class "
             "'$_receiver'.";
         break;
       }
       case _InvocationMirror._CONSTRUCTOR: {
-        msg = "No constructor '$_memberName' declared in class '$_receiver'.";
+        msg = "No constructor '$memberName' declared in class '$_receiver'.";
         break;
       }
       case _InvocationMirror._TOP_LEVEL: {
-        msg = "No top-level $type_str '$_memberName'$args_message declared.";
+        msg = "No top-level $type_str '$memberName'$args_message declared.";
         break;
       }
     }
     return "$msg\n\n";
   }
 
   /* patch */ String toString() {
     StringBuffer actual_buf = new StringBuffer();
     int i = 0;
     if (_arguments == null) {
       // Actual arguments unknown.
       // TODO(srdjan): Remove once arguments are passed for unresolvable
       // static methods.
       actual_buf.write("...");
     } else {
       for (; i < _arguments.length; i++) {
         if (i > 0) {
           actual_buf.write(", ");
         }
         actual_buf.write(Error.safeToString(_arguments[i]));
       }
     }
     if (_namedArguments != null) {
-      _namedArguments.forEach((String key, var value) {
+      _namedArguments.forEach((Symbol key, var value) {
         if (i > 0) {
           actual_buf.write(", ");
         }
-        actual_buf.write(key);
+        actual_buf.write(_collection_dev.Symbol.getName(key));
         actual_buf.write(": ");
         actual_buf.write(Error.safeToString(value));
         i++;
       });
     }
     var args_mismatch = _existingArgumentNames != null;
     StringBuffer msg_buf = new StringBuffer(_developerMessage(args_mismatch));
     String receiver_str;
     var level = (_invocation_type >> _InvocationMirror._CALL_SHIFT) &
         _InvocationMirror._CALL_MASK;
     if ( level == _InvocationMirror._TOP_LEVEL) {
       receiver_str = "top-level";
     } else {
       receiver_str = Error.safeToString(_receiver);
     }
+    var memberName =
+        (_memberName == null) ? "" :_collection_dev.Symbol.getName(_memberName);
     if (!args_mismatch) {
       msg_buf.write(
-          "NoSuchMethodError : method not found: '$_memberName'\n"
+          "NoSuchMethodError : method not found: '$memberName'\n"
           "Receiver: $receiver_str\n"
           "Arguments: [$actual_buf]");
     } else {
       String actualParameters = actual_buf.toString();
       StringBuffer formal_buf = new StringBuffer();
       for (int i = 0; i < _existingArgumentNames.length; i++) {
         if (i > 0) {
           formal_buf.write(", ");
         }
         formal_buf.write(_existingArgumentNames[i]);
       }
       String formalParameters = formal_buf.toString();
       msg_buf.write(
           "NoSuchMethodError: incorrect number of arguments passed to "
-          "method named '$_memberName'\n"
+          "method named '$memberName'\n"
           "Receiver: $receiver_str\n"
           "Tried calling: $_memberName($actualParameters)\n"
           "Found: $_memberName($formalParameters)");
     }
     return msg_buf.toString();
   }
 }
 
 class _JavascriptIntegerOverflowError extends Error {
   final Object _value;
 
   _JavascriptIntegerOverflowError(this._value);
   String toString() => "Javascript Integer Overflow: $_value";
 }