Change the field and constructor parameter types of NoSuchMethodError to Symbol.

sdk/lib/core/errors.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 class Error {
   /**
    * Safely convert a value to a [String] description.
    *
@@ skipping 136 matching lines @@
   FallThroughError();
 }
 
 
 class AbstractClassInstantiationError extends Error {
   final String _className;
   AbstractClassInstantiationError(String this._className);
   String toString() => "Cannot instantiate abstract class: '$_className'";
 }
 
+
 /**
  * Error thrown by the default implementation of [:noSuchMethod:] on [Object].
  */
 class NoSuchMethodError extends Error {
   final Object _receiver;
-  final String _memberName;
+  final Symbol _memberName;
   final List _arguments;
-  final Map<String,dynamic> _namedArguments;
+  final Map<Symbol, dynamic> _namedArguments;
   final List _existingArgumentNames;
 
   /**
    * Create a [NoSuchMethodError] corresponding to a failed method call.
    *
-   * The first parameter to this constructor is the receiver of the method call.
+   * The [receiver] is the receiver of the method call.
    * That is, the object on which the method was attempted called.

[floitsch, 2013/08/30 15:36:44]

attempted to be called.

[Lasse Reichstein Nielsen, 2013/09/02 09:36:29]

I think the original sounds more correct, "attempted to be called" doesn't sound
right.

-   * The second parameter is the name of the called method or accessor.
-   * The third parameter is a list of the positional arguments that the method
-   * was called with.
-   * The fourth parameter is a map from [String] names to the values of named
+   * If this is `null`, it is interpreted as a call to a top-level function

[floitsch, 2013/08/30 15:36:44]

If it is `null` ... (don't use "this")

[Lasse Reichstein Nielsen, 2013/09/02 09:36:29]

As a rule of thumb, I try to avoid "it" as well. It too easily becomes
ambiguous, and since I know what it means, it's hard to see. Change to "If the
receiver is `null`,"

+   * of a library.
+   *
+   * The [memberNamed] is a [Symbol] representing the name of the called method

[floitsch, 2013/08/30 15:36:44]

memberName

[Lasse Reichstein Nielsen, 2013/09/02 09:36:29]

Done.

+   * or accessor. It should not be `null`.
+   *
+   * The [positionalArguments] is a list of the positional arguments that the
+   * method was called with. If `null`, it is considered equivalent to the
+   * empty list.
+   *
+   * The [namedArguments] is a map from [Symbol]s to the values of named
    * arguments that the method was called with.
+   *
    * The optional [exisitingArgumentNames] is the expected parameters of a
    * method with the same name on the receiver, if available. This is
-   * the method that would have been called if the parameters had matched.
+   * the signature of the method that would have been called if the parameters
+   * had matched.
    */
-  NoSuchMethodError(Object this._receiver,
-                    String this._memberName,
-                    List this._arguments,
-                    Map<String,dynamic> this._namedArguments,
+  NoSuchMethodError(Object receiver,
+                    Symbol memberName,
+                    List positionalArguments,
+                    Map<Symbol ,dynamic> namedArguments,
                     [List existingArgumentNames = null])
-      : this._existingArgumentNames = existingArgumentNames;
+      : _receiver = receiver,
+        _memberName = memberName,
+        _arguments = positionalArguments,
+        _namedArguments = namedArguments,
+        _existingArgumentNames = existingArgumentNames;
 
   external String toString();
 }
 
 
 /**
  * The operation was not allowed by the object.
  *
  * This [Error] is thrown when an instance cannot implement one of the methods
  * in its signature.
@@ skipping 82 matching lines @@
  * the first time it is read. If evaluating the initializer expression causes
  * another read of the variable, this error is thrown.
  */
 class CyclicInitializationError extends Error {
   final String variableName;
   CyclicInitializationError([this.variableName]);
   String toString() => variableName == null
       ? "Reading static variable during its initialization"
       : "Reading static variable '$variableName' during its initialization";
 }