net/disk_cache/backend_unittest.cc - Issue 23486006: Track entries pending Doom in SimpleCache backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/backend_unittest.cc

Issue 23486006: Track entries pending Doom in SimpleCache backend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remediation and test update Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/backend_unittest.cc

diff --git a/net/disk_cache/backend_unittest.cc b/net/disk_cache/backend_unittest.cc

index e2144d2b320da3c5ca11d57c29d6064ca1624f14..1a4bb43559368dfcd4770559dcf67a2a66c12e5f 100644

--- a/net/disk_cache/backend_unittest.cc

+++ b/net/disk_cache/backend_unittest.cc

@@ -3113,7 +3113,9 @@ TEST_F(DiskCacheBackendTest, SimpleDoomBetween) {

}

// See http://crbug.com/237450.

-TEST_F(DiskCacheBackendTest, FLAKY_SimpleCacheDoomAll) {

+// TODO(gavinp): Consider enabling this test again when

+// https://codereview.chromium.org/23823002/ lands.

+TEST_F(DiskCacheBackendTest, DISABLED_SimpleCacheDoomAll) {

SetSimpleCacheMode();

BackendDoomAll();

}