Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23486002: Rename BrowserOptions to BrowserFinderOptions. (Closed)

Created:
7 years, 3 months ago by achuithb
Modified:
7 years, 3 months ago
Reviewers:
dtu
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Rename BrowserOptions to BrowserFinderOptions. BUG=269131 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M tools/telemetry/examples/telemetry_perf_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser_options_unittest.py View 4 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/core/chrome/android_browser_finder_unittest.py View 4 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/chrome/desktop_browser_finder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
achuithb
Dave, let me know what you think.
7 years, 3 months ago (2013-08-26 22:25:26 UTC) #1
dtu
lgtm
7 years, 3 months ago (2013-08-27 19:02:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23486002/1
7 years, 3 months ago (2013-08-27 19:30:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23486002/1
7 years, 3 months ago (2013-08-27 19:57:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23486002/1
7 years, 3 months ago (2013-08-28 01:10:20 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-08-28 02:22:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23486002/1
7 years, 3 months ago (2013-08-28 02:41:10 UTC) #7
commit-bot: I haz the power
Change committed as 219909
7 years, 3 months ago (2013-08-28 04:09:06 UTC) #8
dtu
On 2013/08/28 04:09:06, I haz the power (commit-bot) wrote: > Change committed as 219909 Hey, ...
7 years, 3 months ago (2013-08-29 23:04:52 UTC) #9
achuithb
On 2013/08/29 23:04:52, Dave Tu wrote: > On 2013/08/28 04:09:06, I haz the power (commit-bot) ...
7 years, 3 months ago (2013-08-29 23:06:50 UTC) #10
achuithb
7 years, 3 months ago (2013-08-29 23:08:22 UTC) #11
Message was sent while issue was closed. 
On 2013/08/29 23:06:50, achuith.bhandarkar wrote:
> On 2013/08/29 23:04:52, Dave Tu wrote:
> > On 2013/08/28 04:09:06, I haz the power (commit-bot) wrote:
> > > Change committed as 219909
> > 
> > Hey, this change has broken the src/tools/perf unit tests. Be sure to update
> the
> > references in src/tools/perf as well!
> 
> oh, I see them. going to revert this and try again.

oh, nm. going to do a new CL. too disruptive to revert

Powered by Google App Engine
This is Rietveld 408576698