pkg/analyzer/lib/src/generated/type_system.dart - Issue 2348583005: fix #27382, tweak inference heuristic when we have no upper bound info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/type_system.dart

Issue 2348583005: fix #27382, tweak inference heuristic when we have no upper bound info (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/type_system.dart

diff --git a/pkg/analyzer/lib/src/generated/type_system.dart b/pkg/analyzer/lib/src/generated/type_system.dart

index 7582312dba9547e8405154934de6a438f6701e2c..0488553c43014ca14e9210c463bb5279263b57a8 100644

--- a/pkg/analyzer/lib/src/generated/type_system.dart

+++ b/pkg/analyzer/lib/src/generated/type_system.dart

@@ -1604,7 +1604,9 @@ class _StrongInferenceTypeSystem extends StrongTypeSystemImpl {

}

inferredTypes[i] =

- variance.passedIn || lowerBound.isBottom ? upperBound : lowerBound;

+ variance.passedIn && !upperBound.isDynamic || lowerBound.isBottom

+ ? upperBound

+ : lowerBound;

}

// Return the instantiated type.

« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('j') | no next file with comments »