third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html - Issue 2348583004: DevTools: remove unused ConsoleViewMessage.toString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html

Issue 2348583004: DevTools: remove unused ConsoleViewMessage.toString() (Closed)

Patch Set: remove unrelated files Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/console-resource-errors.html ('k') | third_party/WebKit/LayoutTests/inspector/console/console-xpath.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html

diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html b/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html

index b9b464e2447947389f92e325d0cc8e9a3138f9a7..71553f24e29753623d69e4f784e881e4075a80e3 100644

--- a/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html

+++ b/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html

@@ -10,7 +10,7 @@ function test()

InspectorTest.evaluateInPage("loadIframe()");

function addMessage(viewMessage)

{

- if (viewMessage.toString().indexOf("setTimeout") !== -1)

+ if (viewMessage.text.indexOf("setTimeout") !== -1)

lushnikov 2016/09/16 16:47:50 let's not use the .text getter and schedule it for

luoe 2016/09/16 18:58:45 Done.

InspectorTest.expandConsoleMessages(onExpanded);

}