DevTools: remove unused ConsoleViewMessage.toString()

DevTools: remove unused ConsoleViewMessage.toString()

Some inspector LayoutTests were using ConsoleViewMessage.toString() to check
that a message included a substring. Most of the function logic was not
necessary and some cases could be replaced with the .text getter.

BUG=

Committed: https://crrev.com/5d76410721baf333f57d382d8015f200e74e8219
Cr-Commit-Position: refs/heads/master@{#419910}

[luoe, 2016-09-16 00:28:48]

Description was changed from

==========
remove tostring


reset tests, merge


export console should format stack traces

BUG=
==========

to

==========
DevTools: remove unused ConsoleViewMessage.toString()

Some inspector LayoutTests were using ConsoleViewMessage.toString() to check
that a message included a substring. Most of the function logic was not
necessary and some cases could be replaced with the .text getter.

BUG=
==========

[luoe, 2016-09-16 01:11:41]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2016-09-16 16:47:50]

https://codereview.chromium.org/2348583004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html
(right):

https://codereview.chromium.org/2348583004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html:13:
if (viewMessage.text.indexOf("setTimeout") !== -1)
let's not use the .text getter and schedule it for a removal.
Can we use deepTextContent everywhere? If not, let's fallback to the
viewMessage.consoleMessage().messageText

[luoe, 2016-09-16 18:58:45]

Changed all 3 instances to use element().deepTextContent().

https://codereview.chromium.org/2348583004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html
(right):

https://codereview.chromium.org/2348583004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception.html:13:
if (viewMessage.text.indexOf("setTimeout") !== -1)
On 2016/09/16 16:47:50, lushnikov wrote:
> let's not use the .text getter and schedule it for a removal.
> Can we use deepTextContent everywhere? If not, let's fallback to the
> viewMessage.consoleMessage().messageText

Done.

[lushnikov, 2016-09-20 17:59:55]

lgtm

[luoe, 2016-09-20 18:52:33]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-09-20 18:53:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:38:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:38:09]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[luoe, 2016-09-20 20:37:02]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:37:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 23:15:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 23:15:21]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-09-21 00:05:09]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:05:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:12:15]

Description was changed from

==========
DevTools: remove unused ConsoleViewMessage.toString()

Some inspector LayoutTests were using ConsoleViewMessage.toString() to check
that a message included a substring. Most of the function logic was not
necessary and some cases could be replaced with the .text getter.

BUG=
==========

to

==========
DevTools: remove unused ConsoleViewMessage.toString()

Some inspector LayoutTests were using ConsoleViewMessage.toString() to check
that a message included a substring. Most of the function logic was not
necessary and some cases could be replaced with the .text getter.

BUG=
==========

[commit-bot: I haz the power, 2016-09-21 00:12:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 00:14:41]

Description was changed from

==========
DevTools: remove unused ConsoleViewMessage.toString()

Some inspector LayoutTests were using ConsoleViewMessage.toString() to check
that a message included a substring. Most of the function logic was not
necessary and some cases could be replaced with the .text getter.

BUG=
==========

to

==========
DevTools: remove unused ConsoleViewMessage.toString()

Some inspector LayoutTests were using ConsoleViewMessage.toString() to check
that a message included a substring. Most of the function logic was not
necessary and some cases could be replaced with the .text getter.

BUG=

Committed: https://crrev.com/5d76410721baf333f57d382d8015f200e74e8219
Cr-Commit-Position: refs/heads/master@{#419910}
==========

[commit-bot: I haz the power, 2016-09-21 00:14:42]

Patchset 3 (id:??) landed as
https://crrev.com/5d76410721baf333f57d382d8015f200e74e8219
Cr-Commit-Position: refs/heads/master@{#419910}