Split out foreground session tracking from the application code.

Split out foreground session tracking from the application code.

BUG=560466
Committed: https://crrev.com/8f7a51a1143c35d62ec6f30557eeff1d96ababc6
Cr-Commit-Position: refs/heads/master@{#419340}

[Ted C, 2016-09-15 20:00:23]

tedchoc@chromium.org changed reviewers:
+ agrieve@chromium.org, dfalcantara@chromium.org

[Ted C, 2016-09-15 20:00:24]

PTAL

This removes the bulk of the browser logic from ChromeApplication.  Still a
bunch of getters/helpers and some statics that might have a better home, but one
step at a time.

[agrieve, 2016-09-15 20:21:24]

lgtm. Just requesting one extra clean-up because I couldn't un-see it :P

https://codereview.chromium.org/2348583002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
(right):

https://codereview.chromium.org/2348583002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java:56:
if (sInstance == null) sInstance = new ChromeActivitySessionTracker();
nit: assertOnUiThread() for methods in this class?

https://codereview.chromium.org/2348583002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
(right):

https://codereview.chromium.org/2348583002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java:178:
// Internally registers an observer, so not applicable for GC.
Rather than a comment, can you change this to:

ChromeLifetimeController.initialize(); 

So that we don't have a public constructor with side-effects. (move the call to
ApplicationLifetime.addObserver(this); to this new method)

[Ted C, 2016-09-15 22:43:12]

https://codereview.chromium.org/2348583002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
(right):

https://codereview.chromium.org/2348583002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java:56:
if (sInstance == null) sInstance = new ChromeActivitySessionTracker();
On 2016/09/15 20:21:24, agrieve wrote:
> nit: assertOnUiThread() for methods in this class?

Done.

https://codereview.chromium.org/2348583002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
(right):

https://codereview.chromium.org/2348583002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java:178:
// Internally registers an observer, so not applicable for GC.
On 2016/09/15 20:21:24, agrieve wrote:
> Rather than a comment, can you change this to:
> 
> ChromeLifetimeController.initialize(); 
> 
> So that we don't have a public constructor with side-effects. (move the call
to
> ApplicationLifetime.addObserver(this); to this new method)

Done.

[gone, 2016-09-16 18:40:57]

lgtm

https://codereview.chromium.org/2348583002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
(right):

https://codereview.chromium.org/2348583002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java:41:
public static void initialize() {
Don't have to worry about threading do we?

[Ted C, 2016-09-16 19:06:41]

https://codereview.chromium.org/2348583002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
(right):

https://codereview.chromium.org/2348583002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java:41:
public static void initialize() {
On 2016/09/16 18:40:56, dfalcantara wrote:
> Don't have to worry about threading do we?

It is only accessed from the UI thread, but I'm fine adding an assert for that
as well.

findbugs also complained about the same thing, so by adding the assert I feel
less dirty about adding the find bugs exception

[Ted C, 2016-09-16 19:07:02]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-09-16 19:07:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2348583002/#ps100001
(title: "dfalcantara's comments")

[commit-bot: I haz the power, 2016-09-16 19:07:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 20:34:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ted C, 2016-09-16 23:18:11]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-09-16 23:18:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2348583002/#ps120001
(title: "fix test")

[commit-bot: I haz the power, 2016-09-16 23:18:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 00:16:26]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-17 00:18:06]

Description was changed from

==========
Split out foreground session tracking from the application code.

BUG=560466
==========

to

==========
Split out foreground session tracking from the application code.

BUG=560466

Committed: https://crrev.com/8f7a51a1143c35d62ec6f30557eeff1d96ababc6
Cr-Commit-Position: refs/heads/master@{#419340}
==========

[commit-bot: I haz the power, 2016-09-17 00:18:08]

Patchset 7 (id:??) landed as
https://crrev.com/8f7a51a1143c35d62ec6f30557eeff1d96ababc6
Cr-Commit-Position: refs/heads/master@{#419340}