[Remoting Android] Fix split-screen crash

[Remoting Android] Fix split-screen crash

Previously we assumed that DestopView.onAttachedToWindow() will only be called
after DesktopView.init() is called but this is not true when we enter split
screen mode. Since the lifecycle of View.onAttached... and View.onDetached in
relate to Activity.onCreate() and Activity.onDestroy() is not well documented
and behaves quite surprisingly, it may be better to just rely on the lifecycle
of the activity itself.

This CL removes DesktopView's onAttachedToWindow() and onDetachedFromWindow()
overrides and handles initialization and invalidation by Desktop's onCreate()
and onDestroy().

BUG=647823
Committed: https://crrev.com/410a599d9d3c9e49d3b77dbc1063938981fb5b30
Cr-Commit-Position: refs/heads/master@{#419343}

[Yuwei, 2016-09-16 23:18:58]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org

[Yuwei, 2016-09-16 23:18:59]

ptal!

[joedow, 2016-09-16 23:26:00]

lgtm

[Yuwei, 2016-09-16 23:26:29]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:26:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 00:23:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-17 00:26:16]

Description was changed from

==========
[Remoting Android] Fix split-screen crash

Previously we assumed that DestopView.onAttachedToWindow() will only be called
after DesktopView.init() is called but this is not true when we enter split
screen mode. Since the lifecycle of View.onAttached... and View.onDetached in
relate to Activity.onCreate() and Activity.onDestroy() is not well documented
and behaves quite surprisingly, it may be better to just rely on the lifecycle
of the activity itself.

This CL removes DesktopView's onAttachedToWindow() and onDetachedFromWindow()
overrides and handles initialization and invalidation by Desktop's onCreate()
and onDestroy().

BUG=647823
==========

to

==========
[Remoting Android] Fix split-screen crash

Previously we assumed that DestopView.onAttachedToWindow() will only be called
after DesktopView.init() is called but this is not true when we enter split
screen mode. Since the lifecycle of View.onAttached... and View.onDetached in
relate to Activity.onCreate() and Activity.onDestroy() is not well documented
and behaves quite surprisingly, it may be better to just rely on the lifecycle
of the activity itself.

This CL removes DesktopView's onAttachedToWindow() and onDetachedFromWindow()
overrides and handles initialization and invalidation by Desktop's onCreate()
and onDestroy().

BUG=647823

Committed: https://crrev.com/410a599d9d3c9e49d3b77dbc1063938981fb5b30
Cr-Commit-Position: refs/heads/master@{#419343}
==========

[commit-bot: I haz the power, 2016-09-17 00:26:17]

Patchset 2 (id:??) landed as
https://crrev.com/410a599d9d3c9e49d3b77dbc1063938981fb5b30
Cr-Commit-Position: refs/heads/master@{#419343}