Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2348563003: Revert of Run SVGs through nanobench on all Perf bots (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 of https://codereview.chromium.org/2343903002/ ) Reason for revert: Causing failures: https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812 Original issue's description: > Run SVGs through nanobench on all Perf bots. > > Tested with: > python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001 > > Example output is here: > https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410 > Nanobench did run on SVGs. > > BUG=skia:5757 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002 > > Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52 TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5757 Committed: https://skia.googlesource.com/skia/+/be7e3c0db3caa7a86ae233a6bd26281817b83882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M infra/bots/recipes/swarm_perf.py View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Release.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug-Vulkan.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Debug.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Release.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Release.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 2 chunks +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/big_issue_number.json View 1 chunk +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/recipe_with_gerrit_patch.json View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
Created Revert of Run SVGs through nanobench on all Perf bots
4 years, 3 months ago (2016-09-16 19:06:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348563003/1
4 years, 3 months ago (2016-09-16 19:06:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/be7e3c0db3caa7a86ae233a6bd26281817b83882
4 years, 3 months ago (2016-09-16 19:07:00 UTC) #5
rmistry
4 years, 3 months ago (2016-09-19 18:33:06 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2350233002/ by rmistry@google.com.

The reason for reverting is: skbug/5770 has been fixed.
Trying out trybots to see if this can be relanded..

Powered by Google App Engine
This is Rietveld 408576698