Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2348543002: Avoid unnecessary GrShape->SkPath conversion in GrStencilAndCoverPathRenderer (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 2 months ago
Reviewers:
csmartdalton
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid unnecessary GrShape->SkPath conversion in GrStencilAndCoverPathRenderer Also remove redundant param to the path batch constructor. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2348543002 Committed: https://skia.googlesource.com/skia/+/a224bb7027f022cf78376cb7afa2fff83d59153e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M src/gpu/batches/GrDrawPathBatch.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 3 chunks +5 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
bsalomon
4 years, 3 months ago (2016-09-15 17:54:52 UTC) #3
csmartdalton
lgtm
4 years, 3 months ago (2016-09-15 18:53:06 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2342873002 Patch 100001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-15 18:56:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348543002/1
4 years, 2 months ago (2016-10-03 16:27:23 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 16:48:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a224bb7027f022cf78376cb7afa2fff83d59153e

Powered by Google App Engine
This is Rietveld 408576698