Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2348503002: Remove calls to deprecated MessageLoop methods in components/previews/. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in components/previews/. This CL removes calls to MessageLoop::RunUntilIdle from components/previews/. BUG=616447 Committed: https://crrev.com/fb7015f91f55995956e2c07d52cef3b95eb60801 Cr-Commit-Position: refs/heads/master@{#418921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M components/previews/previews_io_data_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/previews/previews_ui_service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-15 17:04:13 UTC) #2
Not at Google. Contact bengr
lgtm
4 years, 3 months ago (2016-09-15 17:38:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348503002/1
4 years, 3 months ago (2016-09-15 18:05:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 18:52:08 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:53:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb7015f91f55995956e2c07d52cef3b95eb60801
Cr-Commit-Position: refs/heads/master@{#418921}

Powered by Google App Engine
This is Rietveld 408576698