Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2348493005: Revert of Use a stamp file when symlinking in GN work around mtime issues (Closed)

Created:
4 years, 3 months ago by afakhry
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use a stamp file when symlinking in GN work around mtime issues (patchset #1 id:1 of https://codereview.chromium.org/2348793002/ ) Reason for revert: Breaks BuildPackages due to GN error (https://bugs.chromium.org/p/chromium/issues/detail?id=647706). BUG=647706 Original issue's description: > Use a stamp file when symlinking in GN work around mtime issues > > Ninja follows a symlink when stat'ing, so you can't use a symlink as an > output and have dirty checking work properly. > https://github.com/ninja-build/ninja/issues/1186 > > BUG=646165 > > Committed: https://crrev.com/fef37c4393d059c9125353928de7e49d4ea04ab4 > Cr-Commit-Position: refs/heads/master@{#419156} TBR=dpranke@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=646165 Committed: https://crrev.com/b15725becf35dd933aedfa818b4b319910016c38 Cr-Commit-Position: refs/heads/master@{#419191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M build/symlink.gni View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
afakhry
Created Revert of Use a stamp file when symlinking in GN work around mtime issues
4 years, 3 months ago (2016-09-16 16:49:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348493005/1
4 years, 3 months ago (2016-09-16 16:49:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 16:50:32 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b15725becf35dd933aedfa818b4b319910016c38 Cr-Commit-Position: refs/heads/master@{#419191}
4 years, 3 months ago (2016-09-16 16:54:19 UTC) #7
Dirk Pranke
4 years, 3 months ago (2016-09-16 16:56:14 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698