Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2348463002: Deprecate PLT UserTiming histograms that are no longer needed. (Closed)

Created:
4 years, 3 months ago by Bryan McQuade
Modified:
4 years, 3 months ago
Reviewers:
Pat Meenan, rkaplow
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate PLT UserTiming histograms that are no longer needed. We will stop logging these and other PLT.* histograms in M56. For the time being, we're deprecating them. BUG=384330 Committed: https://crrev.com/6c88bbfb8f8a74f97de71366c11acf5ab192c70c Cr-Commit-Position: refs/heads/master@{#418913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Bryan McQuade
PTAL, thanks!
4 years, 3 months ago (2016-09-15 15:13:13 UTC) #4
Pat Meenan
lgtm
4 years, 3 months ago (2016-09-15 17:11:33 UTC) #7
rkaplow
lgtm lg, but would you mind adding TODOs at where they are recorded so it ...
4 years, 3 months ago (2016-09-15 17:25:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348463002/1
4 years, 3 months ago (2016-09-15 17:48:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 18:41:23 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:43:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c88bbfb8f8a74f97de71366c11acf5ab192c70c
Cr-Commit-Position: refs/heads/master@{#418913}

Powered by Google App Engine
This is Rietveld 408576698