Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2348453002: Remove NPN from SSLConfig and SSLClientSocket*. (Closed)

Created:
4 years, 3 months ago by Bence
Modified:
4 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NPN from SSLConfig and SSLClientSocket*. Remove: * SSLConfig::npn_protos, * SSLClientSocket::NextProtoStatusToString(), * enum SSLClientSocket::NextProtoStatus, * enum SSLClientSocket::SSLNegotiationExtension, * kDefaultSupportedNPNProtocol, * SSLClientSocketImpl::npn_status_, * SSLClientSocketImpl::negotiation_extension_, * SSLClientSocketImpl::SelectNextProtoCallback, * SSLClientSocketImpl::SSLContext::SelectNextProtoCallback, * HttpNetworkSession::GetNpnProtos(), * NPN unittests. BUG=526713 Committed: https://crrev.com/ce6ea242a36b664f1f56d8174cebef6f341c817e Cr-Commit-Position: refs/heads/master@{#418952}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re: #7. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -217 lines) Patch
M net/http/bidirectional_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/log/net_log_util.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/socket/ssl_client_socket.h View 2 chunks +0 lines, -21 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M net/socket/ssl_client_socket_impl.h View 2 chunks +0 lines, -9 lines 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 1 9 chunks +8 lines, -87 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 5 chunks +4 lines, -50 lines 0 comments Download
M net/ssl/ssl_config.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Bence
David: PTAL. Thank you.
4 years, 3 months ago (2016-09-15 18:16:21 UTC) #6
davidben
lgtm! https://codereview.chromium.org/2348453002/diff/1/net/socket/ssl_client_socket_impl.cc File net/socket/ssl_client_socket_impl.cc (right): https://codereview.chromium.org/2348453002/diff/1/net/socket/ssl_client_socket_impl.cc#newcode1047 net/socket/ssl_client_socket_impl.cc:1047: SSL_set_options(ssl_, SSL_OP_DISABLE_NPN); This line can be removed. (If ...
4 years, 3 months ago (2016-09-15 18:57:00 UTC) #7
Bence
Thank you. https://codereview.chromium.org/2348453002/diff/1/net/socket/ssl_client_socket_impl.cc File net/socket/ssl_client_socket_impl.cc (right): https://codereview.chromium.org/2348453002/diff/1/net/socket/ssl_client_socket_impl.cc#newcode1047 net/socket/ssl_client_socket_impl.cc:1047: SSL_set_options(ssl_, SSL_OP_DISABLE_NPN); On 2016/09/15 18:57:00, davidben wrote: ...
4 years, 3 months ago (2016-09-15 19:01:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348453002/20001
4 years, 3 months ago (2016-09-15 19:02:22 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 20:22:49 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:25:15 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce6ea242a36b664f1f56d8174cebef6f341c817e
Cr-Commit-Position: refs/heads/master@{#418952}

Powered by Google App Engine
This is Rietveld 408576698