Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2348443002: Revert of [TTS] Gather surrounding text on Tap before any UX. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [TTS] Gather surrounding text on Tap before any UX. (patchset #13 id:240001 of https://codereview.chromium.org/2211353002/ ) Reason for revert: Suspected of causing try flakes in ContextualSearchManagerTest#testPromoTapCount: https://bugs.chromium.org/p/chromium/issues/detail?id=647210 Original issue's description: > [TTS] Gather surrounding text on Tap before any UX. > > Extract the text tapped on to use as a signal in Tap Suppression. > The text is extracted before any UX is displayed in order to allow the > tap to be totally ignored when appropriate. Feeding the surrounding > text into the logic of TTS will be done separately. > > This adds several files that are part of the 2016-refactoring. > See crbug.com/624609 and go/cs-refactoring-2016. > > This CL is part of the refactoring-2016 effort, see go/cs-refactoring-2016 > for details. > > BUG=634136, 624609 > > Committed: https://crrev.com/3f11e42880b1b7b6608e2d57fa538552318367ae > Cr-Commit-Position: refs/heads/master@{#418464} TBR=twellington@chromium.org,pedrosimonetti@chromium.org,tedchoc@chromium.org,donnd@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=634136, 624609 Committed: https://crrev.com/1dbb5e84a2682cdbc17093d9e1f5d1c40de46e80 Cr-Commit-Position: refs/heads/master@{#418873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -835 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java View 9 chunks +31 lines, -117 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/action/ResolvedSearchAction.java View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/action/SearchAction.java View 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/action/SearchActionListener.java View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/gesture/SearchGestureHost.java View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 18 chunks +59 lines, -22 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_context.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_context.cc View 1 chunk +4 lines, -11 lines 0 comments Download
D chrome/browser/android/contextualsearch/search_action.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/android/contextualsearch/search_action.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D chrome/browser/android/contextualsearch/search_action_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
Created Revert of [TTS] Gather surrounding text on Tap before any UX.
4 years, 3 months ago (2016-09-15 14:52:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348443002/1
4 years, 3 months ago (2016-09-15 14:53:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 15:40:39 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 15:43:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dbb5e84a2682cdbc17093d9e1f5d1c40de46e80
Cr-Commit-Position: refs/heads/master@{#418873}

Powered by Google App Engine
This is Rietveld 408576698