Add xcode_ninja_target_pattern to xcode-ninja generator

Add xcode_ninja_target_pattern to xcode-ninja generator

Adds new GYP_GENERATOR_FLAG xcode_ninja_target_pattern. This
customization allows for non-executable targets in the xcode_ninja wrapper.

Also changes the name of xcode_ninja_target_filter to
xcode_ninja_executable_target_pattern.

xcode_ninja_executable_target_pattern (default all)
  - Restrict executable targets to this pattern, if set.
xcode_ninja_target_pattern (default none)
  - Include extra targets, such as non-executable targets based on this pattern, if set.

BUG=None
TEST=None
R=mark@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1914

[justincohen, 2014-04-11 18:05:39]

Some small feature requests to the xcode-ninja wrapper.  I expect there will be
a few of these, hopefully all small.

[justincohen, 2014-04-15 16:45:11]

bump?

[Mark Mentovai, 2014-04-15 16:55:45]

https://codereview.chromium.org/234843005/diff/10001/pylib/gyp/xcode_ninja.py
File pylib/gyp/xcode_ninja.py (right):

https://codereview.chromium.org/234843005/diff/10001/pylib/gyp/xcode_ninja.py...
pylib/gyp/xcode_ninja.py:118: Xcode seems to perform poorly with too many
targets, so only included
included -> include

https://codereview.chromium.org/234843005/diff/10001/pylib/gyp/xcode_ninja.py...
pylib/gyp/xcode_ninja.py:138: return True;
No semicolons. Previous and next lines too.

https://codereview.chromium.org/234843005/diff/10001/pylib/gyp/xcode_ninja.py...
pylib/gyp/xcode_ninja.py:178: target_filter =
generator_flags.get('xcode_ninja_target_filter', None)
“filter” sounds like something that can filter to include things or filter to
exclude things. I think you should call “additions” and “filter” something like
“xcode_ninja_target_include_pattern” and “xcode_ninja_target_exclude_pattern”
(matching terminology used elsewhere in GYP), and adjust the names used int he
source code.

[justincohen, 2014-04-15 17:21:04]

https://codereview.chromium.org/234843005/diff/10001/pylib/gyp/xcode_ninja.py
File pylib/gyp/xcode_ninja.py (right):

https://codereview.chromium.org/234843005/diff/10001/pylib/gyp/xcode_ninja.py...
pylib/gyp/xcode_ninja.py:118: Xcode seems to perform poorly with too many
targets, so only included
On 2014/04/15 16:55:46, Mark Mentovai wrote:
> included -> include

Done.

https://codereview.chromium.org/234843005/diff/10001/pylib/gyp/xcode_ninja.py...
pylib/gyp/xcode_ninja.py:138: return True;
On 2014/04/15 16:55:46, Mark Mentovai wrote:
> No semicolons. Previous and next lines too.

Done.

https://codereview.chromium.org/234843005/diff/10001/pylib/gyp/xcode_ninja.py...
pylib/gyp/xcode_ninja.py:178: target_filter =
generator_flags.get('xcode_ninja_target_filter', None)
Neither of these patters really mean exclude.

One means: 
 "If this filter is set, then"
   "Regardless of whether it's executable or not, alway include a target if it
patches FOO"

The other means:
 "If this filter is set, then"
   "If a target is executable and matches FOO, include this target, skip the
rest"

So both are include patterns, but one is for all targets, the other is for
executable targets.

Does that make sense?  What do you suggest?

On 2014/04/15 16:55:46, Mark Mentovai wrote:
> “filter” sounds like something that can filter to include things or filter to
> exclude things. I think you should call “additions” and
“filter” something like
> “xcode_ninja_target_include_pattern” and “xcode_ninja_target_exclude_pattern”
> (matching terminology used elsewhere in GYP), and adjust the names used int he
> source code.

[Mark Mentovai, 2014-04-15 17:46:19]

To help others wrap their heads around that, you should write that kind of
description in the code itself. Then we can think about whether the naming is
appropriate (since I’m still not 100% sure which description goes with which
term).

[justincohen, 2014-04-15 18:12:58]

Added a more detailed comment and changed the names to
xcode_ninja_target_whitelist  and xcode_ninja_target_extras.

What do you think?

[Mark Mentovai, 2014-04-15 18:24:01]

https://codereview.chromium.org/234843005/diff/50001/pylib/gyp/xcode_ninja.py
File pylib/gyp/xcode_ninja.py (right):

https://codereview.chromium.org/234843005/diff/50001/pylib/gyp/xcode_ninja.py...
pylib/gyp/xcode_ninja.py:179: # that match it's regular expression will appear.
Can you reread and revise this sentence?

[justincohen, 2014-04-15 18:36:26]

Oops, thanks.

https://codereview.chromium.org/234843005/diff/50001/pylib/gyp/xcode_ninja.py
File pylib/gyp/xcode_ninja.py (right):

https://codereview.chromium.org/234843005/diff/50001/pylib/gyp/xcode_ninja.py...
pylib/gyp/xcode_ninja.py:179: # that match it's regular expression will appear.
On 2014/04/15 18:24:01, Mark Mentovai wrote:
> Can you reread and revise this sentence?

Done.

[Mark Mentovai, 2014-04-15 18:45:05]

OK, I get it now. One of these controls which executable targets to include
(default all), and the other controls which non-executable targets to include
(default none).

How about using this as a jumping-off point?

xcode_ninja_executable_target_pattern (default all)
xcode_ninja_target_pattern (default none)

The “whitelist” name you have now seems like it could apply equally to
executables and non-executables, which confuses matters.

[justincohen, 2014-05-05 00:31:57]

Sorry for the delay between patches.  How about this?

[Mark Mentovai, 2014-05-05 20:39:10]

OK, LGTM

[justincohen, 2014-05-05 21:32:31]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2014-05-05 21:35:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-05 21:35:12]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[justincohen, 2014-05-06 16:21:18]

Committed patchset #8 manually as r1914.