Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 2348423002: [Signin Error Dialog] (3/3) Added the triggering code (Closed)
Patch Set: Fix malformed function declaration on mac. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index d542a6e031197eb24c9f3efb54123819ddf4aecd..b464f22acbc6d7cea798d950da05b58aa83fbc27 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -2077,7 +2077,7 @@ void ProfileChooserView::CreateAccountButton(views::GridLayout* layout,
views::View* ProfileChooserView::CreateGaiaSigninView(
views::View** signin_content_view) {
- views::WebView* web_view =
+ std::unique_ptr<views::WebView> web_view =
SigninViewControllerDelegateViews::CreateGaiaWebView(
this, view_mode_, browser_, access_point_);
@@ -2099,13 +2099,13 @@ views::View* ProfileChooserView::CreateGaiaSigninView(
}
if (signin_content_view)
- *signin_content_view = web_view;
+ *signin_content_view = web_view.get();
TitleCard* title_card = new TitleCard(l10n_util::GetStringUTF16(message_id),
this,
&gaia_signin_cancel_button_);
return TitleCard::AddPaddedTitleCard(
- web_view, title_card, kPasswordCombinedFixedGaiaViewWidth);
+ web_view.release(), title_card, kPasswordCombinedFixedGaiaViewWidth);
}
views::View* ProfileChooserView::CreateAccountRemovalView() {

Powered by Google App Engine
This is Rietveld 408576698