Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 23484056: [DevTools] Renaming Scripts panel to Sources panel (Closed)

Created:
7 years, 3 months ago by vanihegde
Modified:
7 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, vivekg__, vanivhegde
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[DevTools] Renaming Scripts panel to Sources panel Renaming all the classes and files related to Sources panel from Scripts* to Sources* to match with the inspector UI. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158111

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments incorporated #

Patch Set 3 : Removed extra spaces #

Patch Set 4 : Modified missed files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -2463 lines) Patch
M LayoutTests/http/tests/inspector-enabled/dynamic-scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/debugger-test.js View 6 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/inspector/search/scripts-search-scope.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/debugger/breakpoint-manager-listeners-count.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/copy-stack-trace.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-autocontinue-on-syntax-error.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-breakpoints-not-activated-on-reload.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-change-variable.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/debugger/debugger-eval-while-paused.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-step-in.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-step-into-event-listener.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-step-out.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-step-over.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/debugger-suspend-active-dom-objects.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/dynamic-scripts.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/dynamic-scripts-breakpoints.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/error-in-watch-expressions.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/debugger/event-listener-breakpoints.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/debugger/js-with-inline-stylesheets.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/live-edit.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/live-edit-breakpoints.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/live-edit-no-reveal.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/navigator-view.html View 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/debugger/properties-special.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/debugger/resources/pause-on-blocked-by-csp.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/reveal-not-skipped.html View 5 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/inspector/debugger/script-formatter.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/debugger/script-formatter-breakpoints.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/debugger/script-formatter-console.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/scripts-panel.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/debugger/scripts-sorting.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/debugger/selected-call-frame-after-formatting-source.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/set-breakpoint.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/source-frame-count.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/source-url-comment.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/step-through-event-listeners.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/ui-source-code-display-name.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/watch-expressions-panel-switch.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/debugger/watch-expressions-preserve-expansion.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/debugger/xhr-breakpoints.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/editor/text-editor-search-replace.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/editor/text-editor-selection-to-search.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/extensions/extensions-panel.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/extensions/extensions-panel-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/file-path-scoring.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/filtered-item-selection-dialog-filtering.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/styles/css-live-edit.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tabbed-editors-history.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/uisourcecode-revisions.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/devtools.gyp View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/AdvancedSearchController.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/CPUProfileView.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/CallStackSidebarPane.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/FilteredItemSelectionDialog.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/InspectorFrontendAPI.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/JavaScriptSourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Linkifier.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/NavigatorView.js View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ResourceUtils.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D Source/devtools/front_end/ScriptsNavigator.js View 1 chunk +0 lines, -235 lines 0 comments Download
D Source/devtools/front_end/ScriptsPanel.js View 1 chunk +0 lines, -1488 lines 0 comments Download
D Source/devtools/front_end/ScriptsPanelDescriptor.js View 1 chunk +0 lines, -134 lines 0 comments Download
D Source/devtools/front_end/ScriptsSearchScope.js View 1 chunk +0 lines, -137 lines 0 comments Download
A + Source/devtools/front_end/SourcesNavigator.js View 6 chunks +28 lines, -28 lines 0 comments Download
A + Source/devtools/front_end/SourcesPanel.js View 10 chunks +22 lines, -22 lines 0 comments Download
A + Source/devtools/front_end/SourcesPanelDescriptor.js View 2 chunks +15 lines, -15 lines 0 comments Download
A + Source/devtools/front_end/SourcesSearchScope.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/StylesSidebarPane.js View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/Tests.js View 1 2 3 9 chunks +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/Toolbar.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspector.js View 6 chunks +8 lines, -8 lines 0 comments Download
D Source/devtools/front_end/scriptsPanel.css View 1 chunk +0 lines, -265 lines 0 comments Download
A + Source/devtools/front_end/sourcesPanel.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
vanihegde
Please have a look. Thanks.
7 years, 3 months ago (2013-09-19 10:43:25 UTC) #1
pfeldman
https://codereview.chromium.org/23484056/diff/1/Source/devtools/devtools.gyp File Source/devtools/devtools.gyp (right): https://codereview.chromium.org/23484056/diff/1/Source/devtools/devtools.gyp#newcode148 Source/devtools/devtools.gyp:148: 'front_end/SourcesPanelDescriptor.js', Please maintain alphabetical order. https://codereview.chromium.org/23484056/diff/1/Source/devtools/devtools.gyp#newcode224 Source/devtools/devtools.gyp:224: 'front_end/sourcesPanel.css', ditto
7 years, 3 months ago (2013-09-19 13:12:17 UTC) #2
vanihegde
On 2013/09/19 13:12:17, pfeldman wrote: > https://codereview.chromium.org/23484056/diff/1/Source/devtools/devtools.gyp > File Source/devtools/devtools.gyp (right): > > https://codereview.chromium.org/23484056/diff/1/Source/devtools/devtools.gyp#newcode148 > ...
7 years, 3 months ago (2013-09-20 03:14:23 UTC) #3
pfeldman
lgtm
7 years, 3 months ago (2013-09-20 05:09:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/23484056/11001
7 years, 3 months ago (2013-09-20 05:09:51 UTC) #5
pfeldman
Actually, I'm taking that back, at least those you missed: AdvancedSearchController.js: WebInspector.showPanel("scripts"); AdvancedSearchController.js: anchor.preferredPanel = ...
7 years, 3 months ago (2013-09-20 05:16:59 UTC) #6
vanihegde
On 2013/09/20 05:16:59, pfeldman wrote: > Actually, I'm taking that back, at least those you ...
7 years, 3 months ago (2013-09-20 08:00:35 UTC) #7
pfeldman
lgtm
7 years, 3 months ago (2013-09-20 12:09:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/23484056/17001
7 years, 3 months ago (2013-09-20 12:09:54 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 13:23:12 UTC) #10
Message was sent while issue was closed.
Change committed as 158111

Powered by Google App Engine
This is Rietveld 408576698