Issue 23484037: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23484037: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 2. (Closed)

Created:
7 years, 3 months ago by marja

Modified:
7 years, 2 months ago

Reviewers:
dcarney, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 2. This step reorders the FunctionCallbackInfo fields. BUG= R=dcarney@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16961

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -79 lines)			Patch
M	include/v8.h	View	1 2 3 4 5 6	1 chunk	+7 lines, -7 lines	0 comments	Download
M	src/arguments.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 2 3 4 5	4 chunks	+20 lines, -18 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 2 3 4	2 chunks	+22 lines, -24 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2 3 4	2 chunks	+28 lines, -30 lines	0 comments	Download

Total messages: 6 (0 generated)

Michael Starzinger

LGTM. And of course the code looks completely different on all architectures. Why would it ...

7 years, 2 months ago (2013-09-24 18:24:24 UTC) #5

marja

7 years, 2 months ago (2013-09-26 10:28:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #7 manually as r16961 (presubmit successful).