pkg/intl/lib/generate_localized.dart - Issue 23484033: Avoid name collision with reserved word

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/intl/lib/generate_localized.dart

Issue 23484033: Avoid name collision with reserved word (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/intl/lib/generate_localized.dart

diff --git a/pkg/intl/lib/generate_localized.dart b/pkg/intl/lib/generate_localized.dart

index 285e05e710db5ca5cb10193fd3437250b642471b..1cbaa7a3d9b0a637d17da24096732cbd9f1b3d63 100644

--- a/pkg/intl/lib/generate_localized.dart

+++ b/pkg/intl/lib/generate_localized.dart

@@ -85,7 +85,7 @@ abstract class TranslatedMessage {

* We can't use a hyphen in a Dart library name, so convert the locale

* separator to an underscore.

-String _libraryName(String x) => x.replaceAll('-', '_');

+String _libraryName(String x) => 'lib_' + x.replaceAll('-', '_');

Emily Fortuna 2013/09/11 19:47:43 just as an alternative, consider prefixing it as "

/**

* Generate a file <[generated_file_prefix]>_messages_<[locale]>.dart

« no previous file with comments | « no previous file | pkg/intl/test/message_extraction/foo_messages_all.dart » ('j') | no next file with comments »