Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 2348403002: Reland of Fix async/await memory leak (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Fix async/await memory leak (patchset #1 id:1 of https://codereview.chromium.org/2354473002/ ) Reason for revert: Relanding with faster-running test Original issue's description: > Revert of Fix async/await memory leak (patchset #5 id:80001 of https://codereview.chromium.org/2334323006/ ) > > Reason for revert: > newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop > > Original issue's description: > > Fix async/await memory leak > > > > This patch closes a memory leak in async/await where the desugaring > > was creating a situation analagous to that described in v8:5002. > > Intermediate Promises were being kept alive, so a long-running loop > > would cause linear memory usage on the heap. This patch returns > > undefined to the 'then' callback passed into PerformPromiseThen > > in order to avoid this hazard. Test expectations are fixed to remove > > expecting extraneous events which occurred on Promises that are > > now not given unnecessarily complex resolution paths before being > > thrown away. > > > > BUG=v8:5390 > > > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > > Cr-Commit-Position: refs/heads/master@{#39479} > > TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org > NOTRY=true > BUG=v8:5390 > > Committed: https://crrev.com/196db1999da130019bbf8e3bd65977f840e8afaf > Cr-Commit-Position: refs/heads/master@{#39493} TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=v8:5390 Committed: https://crrev.com/e51482f01f26e0013e6377e85c4d2c41900e403c Cr-Commit-Position: refs/heads/master@{#39508}

Patch Set 1 #

Patch Set 2 : Test is shorter #

Patch Set 3 : Increased iteration count to 8000 to OOM on ia32 #

Patch Set 4 : Break up tests in two #

Patch Set 5 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -27 lines) Patch
M src/js/harmony-async-await.js View 1 3 1 chunk +16 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 2 chunks +33 lines, -9 lines 0 comments Download
A test/mjsunit/harmony/async-await-loop.js View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/async-await-throw-loop.js View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/debug-async-function-async-task-event.js View 1 1 chunk +8 lines, -14 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
Dan Ehrenberg
Created Reland of Fix async/await memory leak
4 years, 3 months ago (2016-09-19 17:33:16 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-09-19 17:34:05 UTC) #2
Dan Ehrenberg
Much shorter test; PTAL
4 years, 3 months ago (2016-09-19 17:42:31 UTC) #3
adamk
lgtm, let's see how the bots like this one
4 years, 3 months ago (2016-09-19 17:45:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348403002/120001
4 years, 3 months ago (2016-09-19 18:05:00 UTC) #10
caitp
lgtm
4 years, 3 months ago (2016-09-19 18:10:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348403002/160001
4 years, 3 months ago (2016-09-19 18:15:00 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:160001)
4 years, 3 months ago (2016-09-19 18:39:49 UTC) #20
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/e51482f01f26e0013e6377e85c4d2c41900e403c Cr-Commit-Position: refs/heads/master@{#39508}
4 years, 3 months ago (2016-09-19 18:41:17 UTC) #22
Dan Ehrenberg
4 years, 3 months ago (2016-09-19 19:29:37 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:160001) has been created in
https://codereview.chromium.org/2348403003/ by littledan@chromium.org.

The reason for reverting is: Still causes issues on bot (sometimes!).

Powered by Google App Engine
This is Rietveld 408576698