Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: runtime/vm/resolver_test.cc

Issue 23484020: Update handling of ambiguous name references (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/resolver.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/resolver_test.cc
===================================================================
--- runtime/vm/resolver_test.cc (revision 27310)
+++ runtime/vm/resolver_test.cc (working copy)
@@ -92,7 +92,6 @@
const String& class_name = String::Handle(String::New(test_class_name));
const String& static_function_name =
String::Handle(String::New(test_static_function_name));
- String& ambiguity_error_msg = String::Handle();
// Now try to resolve and invoke the static function in this class.
{
@@ -103,8 +102,7 @@
static_function_name,
kNumArguments,
Object::empty_array(),
- kResolveType,
- &ambiguity_error_msg));
+ kResolveType));
EXPECT(!function.IsNull()); // No ambiguity error expected.
const Array& args = Array::Handle(Array::New(kNumArguments));
const String& arg0 = String::Handle(String::New("junk"));
@@ -125,8 +123,7 @@
static_function_name,
kNumArguments,
Object::empty_array(),
- kResolveType,
- &ambiguity_error_msg));
+ kResolveType));
EXPECT(bad_function.IsNull()); // No ambiguity error expected.
}
@@ -142,8 +139,7 @@
super_static_function_name,
kNumArguments,
Object::empty_array(),
- kResolveType,
- &ambiguity_error_msg));
+ kResolveType));
EXPECT(!super_function.IsNull()); // No ambiguity error expected.
}
}
@@ -165,9 +161,8 @@
const String& lib_name = String::Handle(String::New(test_library_name));
const Library& lib = Library::Handle(Library::LookupLibrary(lib_name));
ASSERT(!lib.IsNull());
- String& ambiguity_error_msg = String::Handle();
const Class& cls = Class::Handle(lib.LookupClass(
- String::Handle(Symbols::New(test_class_name)), &ambiguity_error_msg));
+ String::Handle(Symbols::New(test_class_name))));
EXPECT(!cls.IsNull()); // No ambiguity error expected.
Instance& receiver = Instance::Handle(Instance::New(cls));
« no previous file with comments | « runtime/vm/resolver.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698