runtime/vm/parser_test.cc - Issue 23484020: Update handling of ambiguous name references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser_test.cc

Issue 23484020: Update handling of ambiguous name references (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/parser_test.cc

===================================================================

--- runtime/vm/parser_test.cc (revision 27297)

+++ runtime/vm/parser_test.cc (working copy)

@@ -16,8 +16,7 @@

void DumpFunction(const Library& lib, const char* cname, const char* fname) {

const String& classname = String::Handle(Symbols::New(cname));

- String& ambiguity_error_msg = String::Handle();

- Class& cls = Class::Handle(lib.LookupClass(classname, &ambiguity_error_msg));

+ Class& cls = Class::Handle(lib.LookupClass(classname));

EXPECT(!cls.IsNull()); // No ambiguity error expected.

regis 2013/09/09 21:29:07 remove comment

hausner 2013/09/09 21:52:08 Done.

String& funcname = String::Handle(String::New(fname));

@@ -51,8 +50,7 @@

bool expect_static,

bool is_final) {

const String& classname = String::Handle(Symbols::New(class_name));

- String& ambiguity_error_msg = String::Handle();

- Class& cls = Class::Handle(lib.LookupClass(classname, &ambiguity_error_msg));

+ Class& cls = Class::Handle(lib.LookupClass(classname));

EXPECT(!cls.IsNull()); // No ambiguity error expected.

regis 2013/09/09 21:29:07 ditto

hausner 2013/09/09 21:52:08 Done.

String& fieldname = String::Handle(String::New(field_name));

@@ -87,8 +85,7 @@

const char* function_name,

bool expect_static) {

const String& classname = String::Handle(Symbols::New(class_name));

- String& ambiguity_error_msg = String::Handle();

- Class& cls = Class::Handle(lib.LookupClass(classname, &ambiguity_error_msg));

+ Class& cls = Class::Handle(lib.LookupClass(classname));

EXPECT(!cls.IsNull()); // No ambiguity error expected.

regis 2013/09/09 21:29:07 ditto

hausner 2013/09/09 21:52:08 Done.

String& functionname = String::Handle(String::New(function_name));