Update handling of ambiguous name references

runtime/vm/mirrors_api_impl.cc

Index: runtime/vm/mirrors_api_impl.cc
===================================================================
--- runtime/vm/mirrors_api_impl.cc	(revision 27297)
+++ runtime/vm/mirrors_api_impl.cc	(working copy)
@@ -163,27 +163,22 @@
     const Library& lib = Library::Cast(obj);
 
     // Case 1.  Lookup the unmodified function name.
-    String& ambiguity_error_msg = String::Handle(isolate);
-    func = lib.LookupFunctionAllowPrivate(func_name, &ambiguity_error_msg);
+    func = lib.LookupFunctionAllowPrivate(func_name);
 
     // Case 2.  Lookup the function without the external setter suffix
     // '='.  Make sure to do this check after the regular lookup, so
     // that we don't interfere with operator lookups (like ==).
-    if (func.IsNull() && ambiguity_error_msg.IsNull() &&
-        HasExternalSetterSuffix(func_name)) {
+    if (func.IsNull() &&  HasExternalSetterSuffix(func_name)) {

[regis, 2013/09/09 21:29:07]

extra space

[hausner, 2013/09/09 21:52:08]

Removed 

On 2013/09/09 21:29:07, regis wrote:

       tmp_name = RemoveExternalSetterSuffix(func_name);
       tmp_name = Field::SetterName(tmp_name);
-      func = lib.LookupFunctionAllowPrivate(tmp_name, &ambiguity_error_msg);
+      func = lib.LookupFunctionAllowPrivate(tmp_name);
     }
 
     // Case 3.  Lookup the function with the getter prefix prepended.
-    if (func.IsNull() && ambiguity_error_msg.IsNull()) {
+    if (func.IsNull()) {
       tmp_name = Field::GetterName(func_name);
-      func = lib.LookupFunctionAllowPrivate(tmp_name, &ambiguity_error_msg);
+      func = lib.LookupFunctionAllowPrivate(tmp_name);
     }
-    if (!ambiguity_error_msg.IsNull()) {
-      return Api::NewError("%s.", ambiguity_error_msg.ToCString());
-    }
   } else {
     return Api::NewError(
         "%s expects argument 'target' to be a class or library.",