Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/code_descriptors_test.cc

Issue 23484020: Update handling of ambiguous name references (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/class_finalizer.cc ('K') | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/code_generator_test.cc » ('j') | runtime/vm/code_generator_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_descriptors_test.cc
===================================================================
--- runtime/vm/code_descriptors_test.cc (revision 27297)
+++ runtime/vm/code_descriptors_test.cc (working copy)
@@ -223,9 +223,8 @@
const String& name = String::Handle(String::New(TestCase::url()));
const Library& lib = Library::Handle(Library::LookupLibrary(name));
EXPECT(!lib.IsNull());
- String& ambiguity_error_msg = String::Handle();
Class& cls = Class::Handle(
- lib.LookupClass(String::Handle(Symbols::New("A")), &ambiguity_error_msg));
+ lib.LookupClass(String::Handle(Symbols::New("A"))));
EXPECT(!cls.IsNull()); // No ambiguity error expected.
regis 2013/09/09 21:29:07 The comment is a bit cryptic now.
hausner 2013/09/09 21:52:08 Done.
// Now compile the two functions 'A.foo' and 'A.moo'
« runtime/vm/class_finalizer.cc ('K') | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/code_generator_test.cc » ('j') | runtime/vm/code_generator_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698