Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 23484019: Refactor KeySystems code to call a function to populate the info. (relanding r221932) (Closed)

Created:
7 years, 3 months ago by ddorwin
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Refactor KeySystems code to call a function to populate the info. (re-land r221932) This allows KeySystems to call GetContentClient()->AddKeySystems() so we can move key system information to chrome/. The new ContentClient API is defined and called, but we still rely on key_systems_info.cc. BUG=224793 TEST=Existing content_unittests and content_browsertests pass. TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222074

Patch Set 1 #

Patch Set 2 : Fix build error (cannot |= an enum) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -188 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A content/public/renderer/key_system_info.h View 1 chunk +65 lines, -0 lines 0 comments Download
A + content/public/renderer/key_system_info.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M content/renderer/media/crypto/key_systems.h View 1 chunk +0 lines, -41 lines 0 comments Download
M content/renderer/media/crypto/key_systems.cc View 11 chunks +81 lines, -67 lines 0 comments Download
M content/renderer/media/crypto/key_systems_info.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/media/crypto/key_systems_info.cc View 1 3 chunks +109 lines, -76 lines 0 comments Download
M content/renderer/media/crypto/key_systems_unittest.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ddorwin
xhwang, PTAL at just the differences in PS2: * PS1 is just the cherry-pick. * ...
7 years, 3 months ago (2013-09-09 18:01:21 UTC) #1
xhwang
lgtm
7 years, 3 months ago (2013-09-09 18:03:24 UTC) #2
ddorwin
7 years, 3 months ago (2013-09-09 19:50:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r222074 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698