Avoid dereferencing a NULL DeviceState in NetworkIconImpl::GetBadges().

Avoid dereferencing a NULL DeviceState in NetworkIconImpl::GetBadges().

BUG=276900
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222117

[stevenjb, 2013-09-09 17:21:23]

https://codereview.chromium.org/23484018/diff/1/ash/system/chromeos/network/n...
File ash/system/chromeos/network/network_icon.cc (right):

https://codereview.chromium.org/23484018/diff/1/ash/system/chromeos/network/n...
ash/system/chromeos/network/network_icon.cc:625: if (!device ||
!device->provider_requires_roaming()) {
Should't this be (device && !device->provider_requires_roaming())? i.e. if
there's no device, err on the side of not showing the badge.

[Ben Chan, 2013-09-09 17:26:49]

On 2013/09/09 17:21:23, stevenjb (chromium) wrote:
>
https://codereview.chromium.org/23484018/diff/1/ash/system/chromeos/network/n...
> File ash/system/chromeos/network/network_icon.cc (right):
> 
>
https://codereview.chromium.org/23484018/diff/1/ash/system/chromeos/network/n...
> ash/system/chromeos/network/network_icon.cc:625: if (!device ||
> !device->provider_requires_roaming()) {
> Should't this be (device && !device->provider_requires_roaming())? i.e. if
> there's no device, err on the side of not showing the badge.

I was thinking the opposite. If the network says it's roaming but we can't tell
from the device that it always requires roaming, we then assume the roaming
badge should be shown.

[stevenjb, 2013-09-09 17:46:36]

lgtm

I guess it doesn't matter, this should really be an edge case and shouldn't last
very long. I just prefer more minimal UI, i.e. less info when we're not certain.

[Ben Chan, 2013-09-09 17:55:16]

On 2013/09/09 17:46:36, stevenjb (chromium) wrote:
> lgtm
> 
> I guess it doesn't matter, this should really be an edge case and shouldn't
last
> very long. I just prefer more minimal UI, i.e. less info when we're not
certain.

Yeah, it's a temporary solution to avoid crashing the browser until we simplify
the UI logic.

[commit-bot: I haz the power, 2013-09-09 19:08:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benchan@chromium.org/23484018/1

[commit-bot: I haz the power, 2013-09-09 22:39:13]

Change committed as 222117